New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make create_typed_array an unsafe function #22640

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
6 participants
@heh9
Copy link
Contributor

heh9 commented Jan 6, 2019

Make create_typed_array function in components/script/dom/vrframedata.rs an unsafe function as it accepts an unsafe pointer
Wrapped the function calls into an unsafe block in components/script/dom/xrview.rs and components/script/dom/vrframedata.rs


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22600 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because the reporter of the issue said it's fine if it compiles with no warning or errors

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 6, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 6, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/vrframedata.rs, components/script/dom/xrview.rs
  • @KiChjang: components/script/dom/vrframedata.rs, components/script/dom/xrview.rs
@highfive

This comment has been minimized.

Copy link

highfive commented Jan 6, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Copy link
Member

jdm commented Jan 7, 2019

@bors-servo r+
Thanks!

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 7, 2019

📌 Commit 8a615fc has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Jan 7, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 7, 2019

⌛️ Testing commit 8a615fc with merge 5039e30...

bors-servo added a commit that referenced this pull request Jan 7, 2019

Auto merge of #22640 - heh9:master, r=jdm
Make create_typed_array an unsafe function

<!-- Please describe your changes on the following line: -->
Make `create_typed_array` function in `components/script/dom/vrframedata.rs` an unsafe function as it accepts an unsafe pointer
Wrapped the function calls into an unsafe block in `components/script/dom/xrview.rs` and `components/script/dom/vrframedata.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22600 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the reporter of the issue said it's fine if it compiles with no warning or errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22640)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 7, 2019

💔 Test failed - mac-rel-wpt4

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Jan 8, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

⌛️ Testing commit 8a615fc with merge 00b89a3...

bors-servo added a commit that referenced this pull request Jan 8, 2019

Auto merge of #22640 - heh9:master, r=jdm
Make create_typed_array an unsafe function

<!-- Please describe your changes on the following line: -->
Make `create_typed_array` function in `components/script/dom/vrframedata.rs` an unsafe function as it accepts an unsafe pointer
Wrapped the function calls into an unsafe block in `components/script/dom/xrview.rs` and `components/script/dom/vrframedata.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22600 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the reporter of the issue said it's fine if it compiles with no warning or errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22640)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

💔 Test failed - mac-rel-wpt3

@CYBAI

This comment has been minimized.

Copy link
Collaborator

CYBAI commented Jan 8, 2019

@bors-servo retry

{
    "status": "TIMEOUT", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/_mozilla/mozilla/referrer-policy/no-referrer-when-downgrade/meta-csp/cross-origin/http-http/iframe-tag/insecure-protocol.swap-origin-redirect.http.html", 
    "line": 59360, 
    "action": "test_result", 
    "expected": "OK"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_equals: It came from a sandboxed iframe expected \"null\" but got \"\"", 
    "stack": "onmessage</onmessage<@http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html:17:7\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1566:20\nTest.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1606:17\n", 
    "subtest": "Check that popups from a sandboxed iframe escape the sandbox if\n       allow-popups-to-escape-sandbox is used", 
    "test": "/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html", 
    "line": 19602, 
    "action": "test_result", 
    "expected": "TIMEOUT"
}
{
    "status": "OK", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html", 
    "line": 19603, 
    "action": "test_result", 
    "expected": "TIMEOUT"
}
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

⌛️ Testing commit 8a615fc with merge 0f55c73...

bors-servo added a commit that referenced this pull request Jan 8, 2019

Auto merge of #22640 - heh9:master, r=jdm
Make create_typed_array an unsafe function

<!-- Please describe your changes on the following line: -->
Make `create_typed_array` function in `components/script/dom/vrframedata.rs` an unsafe function as it accepts an unsafe pointer
Wrapped the function calls into an unsafe block in `components/script/dom/xrview.rs` and `components/script/dom/vrframedata.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22600 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the reporter of the issue said it's fine if it compiles with no warning or errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22640)
<!-- Reviewable:end -->

@highfive highfive removed the S-tests-failed label Jan 8, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

💔 Test failed - mac-rel-css1

@nox

This comment has been minimized.

Copy link
Member

nox commented Jan 8, 2019

@bors-servo retry

@nox nox assigned nox and unassigned jdm Jan 8, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

⌛️ Testing commit 8a615fc with merge e49b7ab...

bors-servo added a commit that referenced this pull request Jan 8, 2019

Auto merge of #22640 - heh9:master, r=jdm
Make create_typed_array an unsafe function

<!-- Please describe your changes on the following line: -->
Make `create_typed_array` function in `components/script/dom/vrframedata.rs` an unsafe function as it accepts an unsafe pointer
Wrapped the function calls into an unsafe block in `components/script/dom/xrview.rs` and `components/script/dom/vrframedata.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22600 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the reporter of the issue said it's fine if it compiles with no warning or errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22640)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

💔 Test failed - mac-rel-css1

@CYBAI

This comment has been minimized.

Copy link
Collaborator

CYBAI commented Jan 8, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

⌛️ Testing commit 8a615fc with merge e7a0a44...

bors-servo added a commit that referenced this pull request Jan 8, 2019

Auto merge of #22640 - heh9:master, r=jdm
Make create_typed_array an unsafe function

<!-- Please describe your changes on the following line: -->
Make `create_typed_array` function in `components/script/dom/vrframedata.rs` an unsafe function as it accepts an unsafe pointer
Wrapped the function calls into an unsafe block in `components/script/dom/xrview.rs` and `components/script/dom/vrframedata.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22600 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the reporter of the issue said it's fine if it compiles with no warning or errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22640)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

@bors-servo bors-servo merged commit 8a615fc into servo:master Jan 8, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment