Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake create_typed_array an unsafe function #22640
Conversation
highfive
assigned
nox
Jan 6, 2019
This comment has been minimized.
This comment has been minimized.
highfive
commented
Jan 6, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon. |
This comment has been minimized.
This comment has been minimized.
highfive
commented
Jan 6, 2019
|
Heads up! This PR modifies the following files:
|
This comment has been minimized.
This comment has been minimized.
highfive
commented
Jan 6, 2019
highfive
added
the
S-awaiting-review
label
Jan 6, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
assigned
jdm
and unassigned
nox
Jan 7, 2019
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Jan 7, 2019
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Jan 7, 2019
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Jan 7, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors-servo retry |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Jan 8, 2019
highfive
added
S-awaiting-merge
and removed
S-tests-failed
labels
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors-servo retry
|
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Jan 8, 2019
highfive
removed
the
S-tests-failed
label
Jan 8, 2019
highfive
added
the
S-awaiting-merge
label
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors-servo retry |
nox
assigned
nox
and unassigned
jdm
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Jan 8, 2019
highfive
added
S-awaiting-merge
and removed
S-tests-failed
labels
Jan 8, 2019
bors-servo
referenced this pull request
Jan 8, 2019
Merged
style: Sync changes from mozilla-central. #22645
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors-servo retry |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Jan 8, 2019
highfive
added
S-awaiting-merge
and removed
S-tests-failed
labels
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
|
|
heh9 commentedJan 6, 2019
•
edited by SimonSapin
Make
create_typed_arrayfunction incomponents/script/dom/vrframedata.rsan unsafe function as it accepts an unsafe pointerWrapped the function calls into an unsafe block in
components/script/dom/xrview.rsandcomponents/script/dom/vrframedata.rs./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is