style: Sync changes from mozilla-central. #22641

emilio · 2019-01-06T23:33:19Z

See each individual commit for details.

This change is


        style: Enable CSS containment for frontend code.

Differential Revision: https://phabricator.services.mozilla.com/D9963


        style: The 'all' property is not animatable.

Since it allows to animate display, which is not good. This is a regression from: https://hg.mozilla.org/mozilla-central/rev/6884ba750aa3 Actually I wonder if the logic shouldn't be the other way around, i.e., a shorthand is animatable if all the longhands are, not if just one. In any case this rolls back to the previous behavior, should we do that, it should be another bug. Differential Revision: https://phabricator.services.mozilla.com/D14632


        style: Make <use> shadow trees lookup keyframe rules in the containin…

…g tree. The same thing we do for rule matching. Differential Revision: https://phabricator.services.mozilla.com/D14548


        style: Cleanup some conversion code dealing with NonNegative.

I'm about to introduce another use of it and I don't want to repeat the same copy-pasta again. Differential Revision: https://phabricator.services.mozilla.com/D14672


        style: Use NonNegative more in the border code.

This ended up not being so small of a patch as I'd have thought, since it propagated a bit. But most of it is mechanical. Interesting part is NonNegativeNumberOrPercentage and the actual uses of the NonNegative stuff and during parsing. This looks like it'd fix a few correctness issues during interpolation for all the types except for BorderRadius and co (which handled it manually). I should write tests for those in a different patch. Differential Revision: https://phabricator.services.mozilla.com/D14673


        style: Use cbindgen for ExtremumLength.

ExtremumLength is the keyword type for css sizing properties, so we could use cbindgen. In Gecko, we use nsStyleCoord to store the sizing properties, and use integer values to check the enum values, so I keep the macros in nsStyleConsts. Even though we need to convert the enum type into integer, we still have benefits to reduce the complexity of converting Rust into C++, and leave the simplified mappings in C++ for better readability. Differential Revision: https://phabricator.services.mozilla.com/D7535


        style: Support unprefixed min-content and max-content.

Support unprefixed min-content and max-content and treat the prefixed version as aliases for 1. width, min-width, max-width if inline-axis is horizontal, and 2. height, min-height, max-height if inline-axis is vertical, and 3. inline-size, min-inline-size, max-inline-size, and 4. flex-basis. Besides, update the test cases to use unprefixed max-content and min-content. Differential Revision: https://phabricator.services.mozilla.com/D7536


        style: Let logical height, block-size, accept keywords.

We should let block-size/min-block-size/max-block-size accept keywords as the initial value, just like width in vertical writing mode or height in horizontal writing mode. Differential Revision: https://phabricator.services.mozilla.com/D14320


        style: Clamp to non-negative value after doing interpolation for circ…

…le(), ellipse(), and inset(). Replace LengthOrPercentage with NonNegativeLengthOrPercentage on ShapeRadius, Circle, Ellipse. And derive ToAnimatedValue for ShapeSource and its related types, so we clamp its interpolated results into non-negative values. (i.e. The radius of circle()/ellipse() and the border-radius of inset().) Note: We may get negative values when using a negative easing function, so the clamp is necessary to avoid the incorrect result or any undefined behavior. Differential Revision: https://phabricator.services.mozilla.com/D14654


        style: Bump smallvec and smallbitvec.

Differential Revision: https://phabricator.services.mozilla.com/D15052


        style: changes to implement enum class for #define NS_STYLE_COLOR_ADJ…

…UST. Differential Revision: https://phabricator.services.mozilla.com/D15284


        style: Update the Rust target version for bindgen.

This brings us alignas support and also associated constants for bitfield enums. Differential Revision: https://phabricator.services.mozilla.com/D15334


        style: Implement the 'overflow-block' media query.

Bug: 1422235 Reviewed-by: emilio


        style: Implement the 'overflow-inline' media query.

Bug: 1422235 Reviewed-by: emilio


        Rename nsIDocument to mozilla::dom::Document.

Summary: Really sorry for the size of the patch. It's mostly automatic s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to add the right namespacing and such. Overall it's not a very interesting patch I think. nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and nsIDocumentInlines.h into DocumentInlines.h. I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it. While fixing up some of the bits I also removed some unneeded OwnerDoc() null checks and such, but I didn't do anything riskier than that. Bug: 1517241 Reviewed-by: smaug


        style: Drop layout.css.box-decoration-break.enabled pref.

It was enabled by default in bug 1006326. Differential Revision: https://phabricator.services.mozilla.com/D15702


        style: Drop layout.css.color-adjust.enabled pref.

It was enabled by default in bug 1209273. Depends on D15702 Differential Revision: https://phabricator.services.mozilla.com/D15703


        style: Drop layout.css.image-orientation.enabled pref.

It was enabled by default in bug 825771. Differential Revision: https://phabricator.services.mozilla.com/D15704


        style: Drop layout.css.isolation.enabled pref.

It was enabled by default in bug 1091885. Differential Revision: https://phabricator.services.mozilla.com/D15705


        style: Drop layout.css.mix-blend-mode.enabled pref.

It was enabled by default in bug 952643. Differential Revision: https://phabricator.services.mozilla.com/D15706


        style: Drop layout.css.scroll-behavior.property-enabled pref.

It was enabled by default in bug 1041833 (for desktops) and bug 1087562 (for Fennec). Differential Revision: https://phabricator.services.mozilla.com/D15707


        style: Drop layout.css.background-blend-mode.enabled pref.

It was enabled by default in bug 970600. Differential Revision: https://phabricator.services.mozilla.com/D15708


        style: Rustfmt recent changes.


        Update lockfile.


        style: Fix gecko build.

highfive · 2019-01-06T23:33:24Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify style code, but no tests are modified. Please consider adding a test!

emilio · 2019-01-06T23:33:29Z

@bors-servo r+

bors-servo · 2019-01-06T23:33:30Z

📌 Commit 4c1076a has been approved by emilio


        Fix Servo build.

emilio · 2019-01-06T23:59:51Z

@bors-servo r+

bors-servo · 2019-01-06T23:59:52Z

📌 Commit 97bd8fc has been approved by emilio

bors-servo · 2019-01-06T23:59:56Z

⌛ Testing commit 97bd8fc with merge 3bf5091...


        Auto merge of #22641 - emilio:gecko-sync, r=emilio

style: Sync changes from mozilla-central. See each individual commit for details.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22641)

bors-servo · 2019-01-07T00:25:25Z

💔 Test failed - linux-rel-wpt


        style: Remove a bunch of unit tests that are not very useful.

And no longer compile. This is fairly well tested in WPT and Gecko tests.

emilio · 2019-01-07T00:27:36Z

@bors-servo r+

Unit tests.

bors-servo · 2019-01-07T00:27:36Z

📌 Commit ecd9794 has been approved by emilio

bors-servo · 2019-01-07T00:27:40Z

⌛ Testing commit ecd9794 with merge bffe2a6...


        Auto merge of #22641 - emilio:gecko-sync, r=emilio

style: Sync changes from mozilla-central. See each individual commit for details.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22641)

bors-servo · 2019-01-07T02:08:53Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: emilio
Pushing bffe2a6 to master...

mbrubeck

83f0286 looks good to me.

emilio · 2019-01-08T00:33:26Z

I guess that meant to go to #22645 :)

emilio · 2019-01-08T00:34:27Z

(Also, thanks!)

dholbert and others added 25 commits Dec 15, 2018

style: Enable CSS containment for frontend code.

4799e83

Differential Revision: https://phabricator.services.mozilla.com/D9963

style: Make <use> shadow trees lookup keyframe rules in the containin…

b59ec2e

…g tree. The same thing we do for rule matching. Differential Revision: https://phabricator.services.mozilla.com/D14548

style: Cleanup some conversion code dealing with NonNegative.

1903559

I'm about to introduce another use of it and I don't want to repeat the same copy-pasta again. Differential Revision: https://phabricator.services.mozilla.com/D14672

style: Bump smallvec and smallbitvec.

7b44418

Differential Revision: https://phabricator.services.mozilla.com/D15052

style: changes to implement enum class for #define NS_STYLE_COLOR_ADJ…

8a6230e

…UST. Differential Revision: https://phabricator.services.mozilla.com/D15284

style: Update the Rust target version for bindgen.

8929087

This brings us alignas support and also associated constants for bitfield enums. Differential Revision: https://phabricator.services.mozilla.com/D15334

style: Implement the 'overflow-block' media query.

81a07b4

Bug: 1422235 Reviewed-by: emilio

style: Implement the 'overflow-inline' media query.

274845f

Bug: 1422235 Reviewed-by: emilio

style: Drop layout.css.box-decoration-break.enabled pref.

d5bee57

It was enabled by default in bug 1006326. Differential Revision: https://phabricator.services.mozilla.com/D15702

style: Drop layout.css.color-adjust.enabled pref.

529ff36

It was enabled by default in bug 1209273. Depends on D15702 Differential Revision: https://phabricator.services.mozilla.com/D15703

style: Drop layout.css.image-orientation.enabled pref.

d862dae

It was enabled by default in bug 825771. Differential Revision: https://phabricator.services.mozilla.com/D15704

style: Drop layout.css.isolation.enabled pref.

0488f81

It was enabled by default in bug 1091885. Differential Revision: https://phabricator.services.mozilla.com/D15705

style: Drop layout.css.mix-blend-mode.enabled pref.

a0d1a03

It was enabled by default in bug 952643. Differential Revision: https://phabricator.services.mozilla.com/D15706

style: Drop layout.css.scroll-behavior.property-enabled pref.

48e4433

It was enabled by default in bug 1041833 (for desktops) and bug 1087562 (for Fennec). Differential Revision: https://phabricator.services.mozilla.com/D15707

style: Drop layout.css.background-blend-mode.enabled pref.

152ef2e

It was enabled by default in bug 970600. Differential Revision: https://phabricator.services.mozilla.com/D15708

style: Rustfmt recent changes.

5f173c4

Update lockfile.

d0eb20c

style: Fix gecko build.

Loading status checks…

4c1076a

highfive assigned avadacatavra Jan 6, 2019

highfive added the S-awaiting-review label Jan 6, 2019

highfive added the S-tests-failed label Jan 6, 2019

Fix Servo build.

Loading status checks…

97bd8fc

highfive added S-awaiting-review and removed S-tests-failed labels Jan 6, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 6, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 7, 2019

style: Remove a bunch of unit tests that are not very useful.

Loading status checks…

ecd9794

And no longer compile. This is fairly well tested in WPT and Gecko tests.

highfive added S-awaiting-review and removed S-tests-failed labels Jan 7, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 7, 2019

bors-servo merged commit ecd9794 into servo:master Jan 7, 2019
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jan 7, 2019

bors-servo mentioned this pull request Jan 7, 2019

Update webrender #22598

Merged

mbrubeck reviewed Jan 8, 2019

View changes

emilio mentioned this pull request Jan 8, 2019

style: Sync changes from mozilla-central. #22645

Merged

servo / servo

style: Sync changes from mozilla-central. #22641

style: Sync changes from mozilla-central. #22641

emilio commented Jan 6, 2019 •

edited by SimonSapin

highfive commented Jan 6, 2019

emilio commented Jan 6, 2019

bors-servo commented Jan 6, 2019

emilio commented Jan 6, 2019

bors-servo commented Jan 6, 2019

bors-servo commented Jan 6, 2019

bors-servo commented Jan 7, 2019

emilio commented Jan 7, 2019

bors-servo commented Jan 7, 2019

bors-servo commented Jan 7, 2019

bors-servo commented Jan 7, 2019

mbrubeck left a comment

emilio commented Jan 8, 2019

emilio commented Jan 8, 2019

servo / servo

Join GitHub today

style: Sync changes from mozilla-central. #22641

style: Sync changes from mozilla-central. #22641

Conversation

emilio commented Jan 6, 2019 • edited by SimonSapin

highfive commented Jan 6, 2019

emilio commented Jan 6, 2019

bors-servo commented Jan 6, 2019

emilio commented Jan 6, 2019

bors-servo commented Jan 6, 2019

bors-servo commented Jan 6, 2019

bors-servo commented Jan 7, 2019

emilio commented Jan 7, 2019

bors-servo commented Jan 7, 2019

bors-servo commented Jan 7, 2019

bors-servo commented Jan 7, 2019

mbrubeck left a comment

emilio commented Jan 8, 2019

emilio commented Jan 8, 2019

emilio commented Jan 6, 2019 •

edited by SimonSapin