Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central. #22641

Merged
merged 27 commits into from Jan 7, 2019
Merged

Commits on Jan 6, 2019

  1. style: The 'all' property is not animatable.

    Since it allows to animate display, which is not good.
    
    This is a regression from:
    
      https://hg.mozilla.org/mozilla-central/rev/6884ba750aa3
    
    Actually I wonder if the logic shouldn't be the other way around, i.e., a
    shorthand is animatable if all the longhands are, not if just one.
    
    In any case this rolls back to the previous behavior, should we do that, it
    should be another bug.
    
    Differential Revision: https://phabricator.services.mozilla.com/D14632
    emilio committed Jan 6, 2019
  2. style: Make <use> shadow trees lookup keyframe rules in the containin…

    …g tree.
    
    The same thing we do for rule matching.
    
    Differential Revision: https://phabricator.services.mozilla.com/D14548
    emilio committed Jan 6, 2019
  3. style: Cleanup some conversion code dealing with NonNegative.

    I'm about to introduce another use of it and I don't want to repeat the same
    copy-pasta again.
    
    Differential Revision: https://phabricator.services.mozilla.com/D14672
    emilio committed Jan 6, 2019
  4. style: Use NonNegative more in the border code.

    This ended up not being so small of a patch as I'd have thought, since it
    propagated a bit. But most of it is mechanical. Interesting part is
    NonNegativeNumberOrPercentage and the actual uses of the NonNegative stuff and
    during parsing.
    
    This looks like it'd fix a few correctness issues during interpolation for all
    the types except for BorderRadius and co (which handled it manually).
    
    I should write tests for those in a different patch.
    
    Differential Revision: https://phabricator.services.mozilla.com/D14673
    emilio committed Jan 6, 2019
  5. style: Use cbindgen for ExtremumLength.

    ExtremumLength is the keyword type for css sizing properties, so we
    could use cbindgen.
    
    In Gecko, we use nsStyleCoord to store the sizing properties, and use
    integer values to check the enum values, so I keep the macros in nsStyleConsts.
    Even though we need to convert the enum type into integer, we still have
    benefits to reduce the complexity of converting Rust into C++, and leave
    the simplified mappings in C++ for better readability.
    
    Differential Revision: https://phabricator.services.mozilla.com/D7535
    BorisChiou authored and emilio committed Jan 6, 2019
  6. style: Support unprefixed min-content and max-content.

    Support unprefixed min-content and max-content and treat the prefixed
    version as aliases for
    1. width, min-width, max-width if inline-axis is horizontal, and
    2. height, min-height, max-height if inline-axis is vertical, and
    3. inline-size, min-inline-size, max-inline-size, and
    4. flex-basis.
    
    Besides, update the test cases to use unprefixed max-content and
    min-content.
    
    Differential Revision: https://phabricator.services.mozilla.com/D7536
    BorisChiou authored and emilio committed Jan 6, 2019
  7. style: Let logical height, block-size, accept keywords.

    We should let block-size/min-block-size/max-block-size accept keywords as the
    initial value, just like width in vertical writing mode or height in horizontal
    writing mode.
    
    Differential Revision: https://phabricator.services.mozilla.com/D14320
    BorisChiou authored and emilio committed Jan 6, 2019
  8. style: Clamp to non-negative value after doing interpolation for circ…

    …le(), ellipse(), and inset().
    
    Replace LengthOrPercentage with NonNegativeLengthOrPercentage on
    ShapeRadius, Circle, Ellipse. And derive ToAnimatedValue for ShapeSource and
    its related types, so we clamp its interpolated results into non-negative
    values. (i.e. The radius of circle()/ellipse() and the border-radius of
    inset().)
    
    Note: We may get negative values when using a negative easing function, so the
    clamp is necessary to avoid the incorrect result or any undefined behavior.
    
    Differential Revision: https://phabricator.services.mozilla.com/D14654
    BorisChiou authored and emilio committed Jan 6, 2019
  9. style: Update the Rust target version for bindgen.

    This brings us alignas support and also associated constants for bitfield enums.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15334
    emilio committed Jan 6, 2019
  10. style: Implement the 'overflow-block' media query.

    Bug: 1422235
    Reviewed-by: emilio
    quasicomputational authored and emilio committed Jan 6, 2019
  11. style: Implement the 'overflow-inline' media query.

    Bug: 1422235
    Reviewed-by: emilio
    quasicomputational authored and emilio committed Jan 6, 2019
  12. Rename nsIDocument to mozilla::dom::Document.

    Summary: Really sorry for the size of the patch. It's mostly automatic
    s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
    add the right namespacing and such.
    
    Overall it's not a very interesting patch I think.
    
    nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
    nsIDocumentInlines.h into DocumentInlines.h.
    
    I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.
    
    While fixing up some of the bits I also removed some unneeded OwnerDoc() null
    checks and such, but I didn't do anything riskier than that.
    
    Bug: 1517241
    Reviewed-by: smaug
    emilio committed Jan 6, 2019
  13. style: Drop layout.css.box-decoration-break.enabled pref.

    It was enabled by default in bug 1006326.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15702
    Hiroyuki Ikezoe authored and emilio committed Jan 6, 2019
  14. style: Drop layout.css.color-adjust.enabled pref.

    It was enabled by default in bug 1209273.
    
    Depends on D15702
    
    Differential Revision: https://phabricator.services.mozilla.com/D15703
    Hiroyuki Ikezoe authored and emilio committed Jan 6, 2019
  15. style: Drop layout.css.image-orientation.enabled pref.

    It was enabled by default in bug 825771.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15704
    Hiroyuki Ikezoe authored and emilio committed Jan 6, 2019
  16. style: Drop layout.css.isolation.enabled pref.

    It was enabled by default in bug 1091885.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15705
    Hiroyuki Ikezoe authored and emilio committed Jan 6, 2019
  17. style: Drop layout.css.mix-blend-mode.enabled pref.

    It was enabled by default in bug 952643.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15706
    Hiroyuki Ikezoe authored and emilio committed Jan 6, 2019
  18. style: Drop layout.css.scroll-behavior.property-enabled pref.

    It was enabled by default in bug 1041833 (for desktops) and
    bug 1087562 (for Fennec).
    
    Differential Revision: https://phabricator.services.mozilla.com/D15707
    Hiroyuki Ikezoe authored and emilio committed Jan 6, 2019
  19. style: Drop layout.css.background-blend-mode.enabled pref.

    It was enabled by default in bug 970600.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15708
    Hiroyuki Ikezoe authored and emilio committed Jan 6, 2019
  20. Update lockfile.

    emilio committed Jan 6, 2019
  21. style: Fix gecko build.

    emilio committed Jan 6, 2019
  22. Fix Servo build.

    emilio committed Jan 6, 2019

Commits on Jan 7, 2019

  1. style: Remove a bunch of unit tests that are not very useful.

    And no longer compile. This is fairly well tested in WPT and Gecko tests.
    emilio committed Jan 7, 2019
You can’t perform that action at this time.