Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement DOM APIs for ChannelSplitterNode #22648
Merged
Conversation
highfive
commented
Jan 8, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
highfive
commented
Jan 8, 2019
|
Heads up! This PR modifies the following files:
|
|
overall looks good! minor fixes (there was a bug in the merger code which may have misled you here, my bad) |
|
Manish and Keith, I appreciate the review comments :) Thanks! Updated the patch. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 10, 2019
Implement DOM APIs for ChannelSplitterNode <!-- Please describe your changes on the following line: --> Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix the second half of #21558 <!-- Either: --> - [x] There are web-platform-tests tests for these changes - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648) <!-- Reviewable:end -->
|
|
|
Oh, you need to add this interface to https://github.com/servo/servo/blob/master/tests/wpt/mozilla/tests/mozilla/interfaces.html |
|
Thanks! I added the interface to the file. By the way, what is the pinging etiquette/protocol in situations such as this one? Should I just wait, add a comment, or use IRC? |
|
Leave a comment or use IRC, your choice |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 11, 2019
Implement DOM APIs for ChannelSplitterNode <!-- Please describe your changes on the following line: --> Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix the second half of #21558 <!-- Either: --> - [x] There are web-platform-tests tests for these changes - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Jan 12, 2019
Implement DOM APIs for ChannelSplitterNode <!-- Please describe your changes on the following line: --> Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix the second half of #21558 <!-- Either: --> - [x] There are web-platform-tests tests for these changes - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648) <!-- Reviewable:end -->
|
|
|
|
@bors-servo retry |
|
Probably a new intermittent |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 12, 2019
Implement DOM APIs for ChannelSplitterNode <!-- Please describe your changes on the following line: --> Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix the second half of #21558 <!-- Either: --> - [x] There are web-platform-tests tests for these changes - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 12, 2019
Implement DOM APIs for ChannelSplitterNode <!-- Please describe your changes on the following line: --> Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix the second half of #21558 <!-- Either: --> - [x] There are web-platform-tests tests for these changes - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
collares commentedJan 8, 2019
•
edited by SimonSapin
Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is