Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a bunch of layout queries morally safer #22658

Merged
merged 3 commits into from Jan 10, 2019
Merged

Make a bunch of layout queries morally safer #22658

merged 3 commits into from Jan 10, 2019

Conversation

@nox
Copy link
Member

nox commented Jan 9, 2019 •
edited by SimonSapin

This change is Reviewable
nox added 3 commits Jan 9, 2019
@nox
Remove unstable unused feature in script_layout_interface
1120da6
@nox
Move is_image_data to the layout crate
ddef621 
It's only used there.
@nox
Make a bunch of layout queries morally safer
Loading status checks…
3ccda7f
@highfive
Copy link

highfive commented Jan 9, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/node.rs, components/script/dom/htmlelement.rs, components/script/dom/htmlinputelement.rs, components/script/dom/window.rs
  • @KiChjang: components/script/dom/node.rs, components/script/dom/htmlelement.rs, components/script/dom/htmlinputelement.rs, components/script/dom/window.rs
  • @emilio: components/layout/construct.rs, components/layout/query.rs
@highfive
Copy link

highfive commented Jan 9, 2019

warning Warning warning

  • These commits modify layout and script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Jan 9, 2019

r? @SimonSapin
@highfive highfive assigned SimonSapin and unassigned emilio Jan 9, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Jan 9, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2019

📌 Commit 3ccda7f has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2019

⌛ Testing commit 3ccda7f with merge f4334c1...
bors-servo added a commit that referenced this pull request Jan 9, 2019
@bors-servo
Auto merge of #22658 - servo:next-layout, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4334c1 
Make a bunch of layout queries morally safer

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22658)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2019

💔 Test failed - linux-rel-wpt
@ferjm
Copy link
Member

ferjm commented Jan 9, 2019

@bors-servo retry

This was me updating gstreamer binaries. Sorry about that.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2019

⌛ Testing commit 3ccda7f with merge e6e00cb...
bors-servo added a commit that referenced this pull request Jan 9, 2019
@bors-servo
Auto merge of #22658 - servo:next-layout, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e6e00cb 
Make a bunch of layout queries morally safer

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22658)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: SimonSapin
Pushing e6e00cb to master...
@bors-servo bors-servo merged commit 3ccda7f into master Jan 10, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox mentioned this pull request Jan 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @SimonSapin @bors-servo @ferjm @emilio
You can’t perform that action at this time.