Implement formdata event #22660

CYBAI · 2019-01-09T16:18:34Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22654
There are tests for these changes

This change is

highfive · 2019-01-09T16:18:41Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/formdataevent.rs, components/script/dom/htmlformelement.rs, components/script/dom/mod.rs, components/script/dom/webidls/FormDataEvent.webidl, components/script/dom/formdata.rs
@KiChjang: components/script/dom/formdataevent.rs, components/script/dom/htmlformelement.rs, components/script/dom/mod.rs, components/script/dom/webidls/FormDataEvent.webidl, components/script/dom/formdata.rs

servo-wpt-sync · 2019-01-09T16:19:43Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14768.

tests/wpt/web-platform-tests/xhr/formdata.htm

jdm

Great work! These changes were easy to read and understand.

components/script/dom/htmlformelement.rs

components/script/dom/formdataevent.rs

components/script/dom/formdata.rs

components/script/dom/webidls/FormDataEvent.webidl

tests/wpt/web-platform-tests/xhr/formdata.htm

servo-wpt-sync · 2019-01-10T05:42:30Z

No upstreamable changes; closed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14768.

CYBAI · 2019-01-10T05:43:49Z

Just updated some easy fix and remove the update test case commit! Will keep working on addressing other comments!

CYBAI · 2019-01-10T11:00:22Z

@bors-servo try=wpt

bors-servo · 2019-01-10T11:00:28Z

⌛ Trying commit 038c83b with merge d10915a...


        Auto merge of #22660 - CYBAI:formdataevent, r=<try>

Implement formdata event --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22654 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22660)

bors-servo · 2019-01-10T11:21:32Z

💔 Test failed - linux-rel-css

components/script/dom/element.rs

components/script/dom/webidls/FormDataEvent.webidl

jdm

Looking good!

CYBAI · 2019-01-22T18:32:15Z

@bors-servo ping 🤔

bors-servo · 2019-01-22T18:32:16Z

😪 I'm awake I'm awake

jdm · 2019-01-22T18:45:31Z

@bors-servo r+

bors-servo · 2019-01-22T18:45:31Z

📌 Commit 3b9ab34 has been approved by jdm

bors-servo · 2019-01-22T18:45:36Z

⌛ Testing commit 3b9ab34 with merge 461bce1...


        Auto merge of #22660 - CYBAI:formdataevent, r=jdm

Implement formdata event --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22654 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22660)

jdm · 2019-01-22T18:46:18Z

Looks like the webhook just missed the previous notification, since this PR did not show up in the homu queue.

CYBAI · 2019-01-22T18:49:26Z

Maybe I should wait a minute to ask homu to approve after I force pushed 😂 Thanks for the approval!

bors-servo · 2019-01-22T20:00:52Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 461bce1 to master...


        Make a workaround for the test with about:blank onload

As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.


        Make a workaround for the test with about:blank onload

As jdm mentioned in servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.


        Make a workaround for the test with about:blank onload

As jdm mentioned in servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995


        Make a workaround for the test with about:blank onload

As jdm mentioned in servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995 UltraBlame original commit: 0395694ee9fca6762acd0e74ac71b5a94e8ba97e


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995 UltraBlame original commit: 00fc0cf059cdcaae2b264d24d8a13edd00211d0a


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995 UltraBlame original commit: 0395694ee9fca6762acd0e74ac71b5a94e8ba97e


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995 UltraBlame original commit: 00fc0cf059cdcaae2b264d24d8a13edd00211d0a


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995 UltraBlame original commit: 0395694ee9fca6762acd0e74ac71b5a94e8ba97e


        Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly

Automatic update from web-platform-tests Make a workaround for the test with about:blank onload As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs. -- wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1 wpt-pr: 14995 UltraBlame original commit: 00fc0cf059cdcaae2b264d24d8a13edd00211d0a

highfive assigned SimonSapin Jan 9, 2019

highfive added the S-awaiting-review label Jan 9, 2019

servo-wpt-sync mentioned this pull request Jan 9, 2019

Implement formdata event web-platform-tests/wpt#14768

Closed

CYBAI reviewed Jan 9, 2019

View changes

tests/wpt/web-platform-tests/xhr/formdata.htm Outdated Show resolved Hide resolved

CYBAI requested a review from jdm Jan 9, 2019

jdm requested changes Jan 9, 2019

View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Jan 9, 2019

jdm assigned jdm and unassigned SimonSapin Jan 9, 2019

CYBAI force-pushed the CYBAI:formdataevent branch from eff179b to 10c7ceb Jan 10, 2019

highfive added S-awaiting-review and removed S-needs-code-changes labels Jan 10, 2019

CYBAI added S-needs-code-changes and removed S-awaiting-review labels Jan 10, 2019

CYBAI force-pushed the CYBAI:formdataevent branch from 10c7ceb to 038c83b Jan 10, 2019

highfive added S-awaiting-review and removed S-needs-code-changes labels Jan 10, 2019

highfive added the S-tests-failed label Jan 10, 2019

jdm reviewed Jan 10, 2019

View changes

components/script/dom/element.rs Outdated Show resolved Hide resolved

components/script/dom/element.rs Outdated Show resolved Hide resolved

components/script/dom/webidls/FormDataEvent.webidl Show resolved Hide resolved

jdm requested changes Jan 10, 2019

View changes

jdm added the S-needs-code-changes label Jan 10, 2019

CYBAI removed S-awaiting-review S-needs-rebase labels Jan 22, 2019

highfive removed the S-awaiting-merge label Jan 22, 2019

CYBAI deleted the CYBAI:formdataevent branch Jan 22, 2019

jdm mentioned this pull request Jan 25, 2019

Refactor follow_hyperlink and callers to match specification algorithms #22761

Closed

gterzian added a commit to gterzian/servo that referenced this pull request Jan 30, 2019

Make a workaround for the test with about:blank onload

c96cae3

As jdm mentioned in servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

aditj added a commit to aditj/servo that referenced this pull request Jan 30, 2019

Make a workaround for the test with about:blank onload

111705e

As jdm mentioned in servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

aditj added a commit to aditj/servo that referenced this pull request Mar 15, 2019

Make a workaround for the test with about:blank onload

af35a25

As jdm mentioned in servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

pshaughn mentioned this pull request Dec 6, 2019

Implement onformdata as an event handler IDL attribute #25183

Closed

servo / servo

Implement formdata event #22660

Implement formdata event #22660

CYBAI commented Jan 9, 2019 •

edited by SimonSapin

highfive commented Jan 9, 2019

servo-wpt-sync commented Jan 9, 2019

jdm left a comment

servo-wpt-sync commented Jan 10, 2019

CYBAI commented Jan 10, 2019

CYBAI commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

jdm left a comment

CYBAI commented Jan 22, 2019

bors-servo commented Jan 22, 2019

jdm commented Jan 22, 2019

bors-servo commented Jan 22, 2019

bors-servo commented Jan 22, 2019

jdm commented Jan 22, 2019

CYBAI commented Jan 22, 2019

bors-servo commented Jan 22, 2019

servo / servo

Join GitHub today

Implement formdata event #22660

Implement formdata event #22660

Conversation

CYBAI commented Jan 9, 2019 • edited by SimonSapin

highfive commented Jan 9, 2019

servo-wpt-sync commented Jan 9, 2019

jdm left a comment

servo-wpt-sync commented Jan 10, 2019

CYBAI commented Jan 10, 2019

CYBAI commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

jdm left a comment

CYBAI commented Jan 22, 2019

bors-servo commented Jan 22, 2019

jdm commented Jan 22, 2019

bors-servo commented Jan 22, 2019

bors-servo commented Jan 22, 2019

jdm commented Jan 22, 2019

CYBAI commented Jan 22, 2019

bors-servo commented Jan 22, 2019

CYBAI commented Jan 9, 2019 •

edited by SimonSapin