New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement formdata event #22660

Merged
merged 3 commits into from Jan 22, 2019

Conversation

Projects
None yet
6 participants
@CYBAI
Copy link
Collaborator

CYBAI commented Jan 9, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22654
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 9, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/formdataevent.rs, components/script/dom/htmlformelement.rs, components/script/dom/mod.rs, components/script/dom/webidls/FormDataEvent.webidl, components/script/dom/formdata.rs
  • @KiChjang: components/script/dom/formdataevent.rs, components/script/dom/htmlformelement.rs, components/script/dom/mod.rs, components/script/dom/webidls/FormDataEvent.webidl, components/script/dom/formdata.rs
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Jan 9, 2019

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14768.

@CYBAI CYBAI requested a review from jdm Jan 9, 2019

@jdm
Copy link
Member

jdm left a comment

Great work! These changes were easy to read and understand.

Show resolved Hide resolved components/script/dom/htmlformelement.rs Outdated
Show resolved Hide resolved components/script/dom/htmlformelement.rs Outdated
Show resolved Hide resolved components/script/dom/formdataevent.rs Outdated
Show resolved Hide resolved components/script/dom/formdataevent.rs Outdated
Show resolved Hide resolved components/script/dom/formdata.rs Outdated
Show resolved Hide resolved components/script/dom/webidls/FormDataEvent.webidl
Show resolved Hide resolved tests/wpt/web-platform-tests/xhr/formdata.htm Outdated

@jdm jdm assigned jdm and unassigned SimonSapin Jan 9, 2019

@CYBAI CYBAI force-pushed the CYBAI:formdataevent branch from eff179b to 10c7ceb Jan 10, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Jan 10, 2019

No upstreamable changes; closed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14768.

@CYBAI

This comment has been minimized.

Copy link
Collaborator Author

CYBAI commented Jan 10, 2019

Just updated some easy fix and remove the update test case commit! Will keep working on addressing other comments!

@CYBAI CYBAI force-pushed the CYBAI:formdataevent branch from 10c7ceb to 038c83b Jan 10, 2019

@CYBAI

This comment has been minimized.

Copy link
Collaborator Author

CYBAI commented Jan 10, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

⌛️ Trying commit 038c83b with merge d10915a...

bors-servo added a commit that referenced this pull request Jan 10, 2019

Auto merge of #22660 - CYBAI:formdataevent, r=<try>
Implement formdata event

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22654
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22660)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

💔 Test failed - linux-rel-css

Show resolved Hide resolved components/script/dom/element.rs Outdated
Show resolved Hide resolved components/script/dom/element.rs Outdated
Show resolved Hide resolved components/script/dom/webidls/FormDataEvent.webidl
@jdm
Copy link
Member

jdm left a comment

Looking good!

CYBAI added some commits Jan 9, 2019

Make a workaround for the test with about:blank onload
As jdm mentioned in #22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

@CYBAI CYBAI force-pushed the CYBAI:formdataevent branch from 4814ba3 to 3b9ab34 Jan 22, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Jan 22, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14995.

servo-wpt-sync added a commit to servo-wpt-sync/web-platform-tests that referenced this pull request Jan 22, 2019

Make a workaround for the test with about:blank onload
As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.
@CYBAI

This comment has been minimized.

Copy link
Collaborator Author

CYBAI commented Jan 22, 2019

@bors-servo r=jdm

@CYBAI

This comment has been minimized.

Copy link
Collaborator Author

CYBAI commented Jan 22, 2019

@bors-servo ping 🤔

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 22, 2019

😪 I'm awake I'm awake

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Jan 22, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 22, 2019

📌 Commit 3b9ab34 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 22, 2019

⌛️ Testing commit 3b9ab34 with merge 461bce1...

bors-servo added a commit that referenced this pull request Jan 22, 2019

Auto merge of #22660 - CYBAI:formdataevent, r=jdm
Implement formdata event

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22654
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22660)
<!-- Reviewable:end -->
@jdm

This comment has been minimized.

Copy link
Member

jdm commented Jan 22, 2019

Looks like the webhook just missed the previous notification, since this PR did not show up in the homu queue.

@CYBAI

This comment has been minimized.

Copy link
Collaborator Author

CYBAI commented Jan 22, 2019

Maybe I should wait a minute to ask homu to approve after I force pushed 😂 Thanks for the approval!

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 22, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 461bce1 to master...

@bors-servo bors-servo merged commit 3b9ab34 into servo:master Jan 22, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

servo-wpt-sync added a commit to web-platform-tests/wpt that referenced this pull request Jan 22, 2019

Make a workaround for the test with about:blank onload
As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

@CYBAI CYBAI deleted the CYBAI:formdataevent branch Jan 22, 2019

gterzian added a commit to gterzian/servo that referenced this pull request Jan 30, 2019

Make a workaround for the test with about:blank onload
As jdm mentioned in servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

aditj added a commit to aditj/servo that referenced this pull request Jan 30, 2019

Make a workaround for the test with about:blank onload
As jdm mentioned in servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 5, 2019

Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly
Automatic update from web-platform-tests
Make a workaround for the test with about:blank onload

As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

--

wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1
wpt-pr: 14995

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 6, 2019

Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly
Automatic update from web-platform-tests
Make a workaround for the test with about:blank onload

As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

--

wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1
wpt-pr: 14995

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 7, 2019

Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly
Automatic update from web-platform-tests
Make a workaround for the test with about:blank onload

As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

--

wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1
wpt-pr: 14995

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 8, 2019

Bug 1523562 [wpt PR 14995] - Implement formdata event, a=testonly
Automatic update from web-platform-tests
Make a workaround for the test with about:blank onload

As jdm mentioned in servo/servo#22660 (comment), the initial about:blank load event can be fired before the form navigation occurs.

--

wpt-commits: c6fa4b6176b668287fef2d3ebdc54d5f992f7ca1
wpt-pr: 14995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment