New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull mime 0.3.13 and fix a MIME comparison in EventSource #22678

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@nox
Copy link
Member

nox commented Jan 12, 2019

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 12, 2019

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 12, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jan 12, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 12, 2019

⌛️ Trying commit baa7eba with merge 9848873...

bors-servo added a commit that referenced this pull request Jan 12, 2019

Auto merge of #22678 - nox:mime, r=<try>
Pull mime 0.3.13 and fix a MIME comparison in EventSource

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22678)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 12, 2019

💔 Test failed - linux-rel-css

@nox nox force-pushed the nox:mime branch from baa7eba to c38abed Jan 12, 2019

@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jan 12, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 12, 2019

⌛️ Trying commit c38abed with merge f535861...

bors-servo added a commit that referenced this pull request Jan 12, 2019

Auto merge of #22678 - nox:mime, r=<try>
Pull mime 0.3.13 and fix a MIME comparison in EventSource

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22678)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 12, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

nox added some commits Jan 12, 2019

Tweak the MIME comparison in EventSource
MIME parameters should not be inspected when checking for text/event-stream.

@nox nox force-pushed the nox:mime branch from c38abed to 8611b0f Jan 14, 2019

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Jan 14, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 14, 2019

📌 Commit 8611b0f has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 14, 2019

⌛️ Testing commit 8611b0f with merge b1a4913...

bors-servo added a commit that referenced this pull request Jan 14, 2019

Auto merge of #22678 - nox:mime, r=SimonSapin
Pull mime 0.3.13 and fix a MIME comparison in EventSource

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22678)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 14, 2019

@bors-servo bors-servo merged commit 8611b0f into servo:master Jan 14, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Jan 14, 2019

Merged

Update webrender #22598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment