Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media cache and buffering support #22692

Merged
merged 2 commits into from Jan 17, 2019
Merged

Media cache and buffering support #22692

merged 2 commits into from Jan 17, 2019

Conversation

@ferjm
Copy link
Member

@ferjm ferjm commented Jan 15, 2019

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22055 and fix #22296

This change is Reviewable

@highfive
Copy link

@highfive highfive commented Jan 15, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/timeranges.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/webidls/HTMLMediaElement.webidl
  • @KiChjang: components/script/dom/timeranges.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/webidls/HTMLMediaElement.webidl
@ferjm
Copy link
Member Author

@ferjm ferjm commented Jan 15, 2019

Seeking performs so much better with these patches

ezgif-4-d15006f36ead

@ferjm ferjm force-pushed the ferjm:buffering branch from 7974e4f to dfe3887 Jan 15, 2019
@ferjm
Copy link
Member Author

@ferjm ferjm commented Jan 15, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 15, 2019

Trying commit dfe3887 with merge 788349b...

bors-servo added a commit that referenced this pull request Jan 15, 2019
Media cache and buffering support

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22055 and fix #22296

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22692)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 15, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

@ferjm ferjm force-pushed the ferjm:buffering branch from dfe3887 to 4cf6871 Jan 17, 2019
@ferjm ferjm force-pushed the ferjm:buffering branch from 4cf6871 to 4b23c63 Jan 17, 2019
@ferjm
Copy link
Member Author

@ferjm ferjm commented Jan 17, 2019

r? @ceyusa

@ceyusa
Copy link
Collaborator

@ceyusa ceyusa commented Jan 17, 2019

looks ok!

r+

@ferjm
Copy link
Member Author

@ferjm ferjm commented Jan 17, 2019

@bors-servo r=ceyusa

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 17, 2019

📌 Commit 4b23c63 has been approved by ceyusa

@ferjm
Copy link
Member Author

@ferjm ferjm commented Jan 17, 2019

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 17, 2019

😪 I'm awake I'm awake

@ferjm ferjm closed this Jan 17, 2019
@ferjm ferjm reopened this Jan 17, 2019
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 17, 2019

Testing commit 4b23c63 with merge ab4c0a4...

bors-servo added a commit that referenced this pull request Jan 17, 2019
Media cache and buffering support

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22055 and fix #22296

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22692)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 17, 2019

💔 Test failed - linux-rel-css

@ferjm
Copy link
Member Author

@ferjm ferjm commented Jan 17, 2019

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 17, 2019

Testing commit 4b23c63 with merge 665568c...

bors-servo added a commit that referenced this pull request Jan 17, 2019
Media cache and buffering support

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22055 and fix #22296

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22692)
<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Jan 17, 2019

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 17, 2019

Testing commit 4b23c63 with merge 866fd55...

bors-servo added a commit that referenced this pull request Jan 17, 2019
Media cache and buffering support

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22055 and fix #22296

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22692)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jan 17, 2019

@bors-servo bors-servo merged commit 4b23c63 into servo:master Jan 17, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@bors-servo
homu Test successful
Details
@ferjm ferjm deleted the ferjm:buffering branch Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants