New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic when executing userscripts #22697

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
6 participants
@jdm
Copy link
Member

jdm commented Jan 15, 2019

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22685
  • These changes do not require tests because there is no automation for testing userscripts.

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 15, 2019

Heads up! This PR modifies the following files:

@jdm

This comment has been minimized.

Copy link
Member Author

jdm commented Jan 15, 2019

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 15, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive assigned Manishearth and unassigned avadacatavra Jan 15, 2019

@asajeffrey

This comment has been minimized.

Copy link
Member

asajeffrey commented Jan 15, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 15, 2019

📌 Commit 66c2e42 has been approved by asajeffrey

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 15, 2019

⌛️ Testing commit 66c2e42 with merge 91d7747...

bors-servo added a commit that referenced this pull request Jan 15, 2019

Auto merge of #22697 - jdm:user-script, r=asajeffrey
Don't panic when executing userscripts

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22685
- [x] These changes do not require tests because there is no automation for testing userscripts.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22697)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 15, 2019

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member Author

jdm commented Jan 15, 2019

bors-servo added a commit that referenced this pull request Jan 16, 2019

Auto merge of #22697 - jdm:user-script, r=asajeffrey
Don't panic when executing userscripts

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22685
- [x] These changes do not require tests because there is no automation for testing userscripts.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22697)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 16, 2019

⌛️ Testing commit 66c2e42 with merge 7400219...

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 16, 2019

@bors-servo bors-servo merged commit 66c2e42 into servo:master Jan 16, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment