Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable 32bit builds. #2274
Enable 32bit builds. #2274
Conversation
hoppipolla-critic-bot
commented
Apr 30, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1429 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
larsberg
commented
Jun 30, 2014
|
I think you've got the wrong lars berg, good luck with the review though |
|
You'll need to push your latest rust-mozjs changes. |
|
Sorry @larsberg! I meant @larsbergstrom. @jdm rust-mozjs is pushed and awaiting your review. |
|
@metajack Did you verify that this doesn't break Android builds? (or at least not break them any further ) |
|
Ok, this is ready to review and to land. All the submodules are landed except for the minor rust-phf update. |
You specify a 32bit build by setting --target on configure.
metajack commentedApr 30, 2014
You specify a 32bit build by setting --target on configure.
Depends on servo/rust-mozjs#77