Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 32bit builds. #2274

Merged
merged 1 commit into from Aug 15, 2014
Merged

Enable 32bit builds. #2274

merged 1 commit into from Aug 15, 2014

Conversation

@metajack
Copy link
Contributor

metajack commented Apr 30, 2014

You specify a 32bit build by setting --target on configure.

Depends on servo/rust-mozjs#77

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 30, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1429

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack
Copy link
Contributor Author

metajack commented Jun 30, 2014

This is ready for review now. Critic isn't happy about my force pushes, so please review in GitHub. r? @larsberg or @jdm

@larsberg
Copy link

larsberg commented Jun 30, 2014

I think you've got the wrong lars berg, good luck with the review though

@jdm
Copy link
Member

jdm commented Jun 30, 2014

You'll need to push your latest rust-mozjs changes.

@metajack
Copy link
Contributor Author

metajack commented Jun 30, 2014

Sorry @larsberg! I meant @larsbergstrom.

@jdm rust-mozjs is pushed and awaiting your review.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 1, 2014

@metajack Did you verify that this doesn't break Android builds? (or at least not break them any further )

@metajack
Copy link
Contributor Author

metajack commented Aug 11, 2014

Ok, this is ready to review and to land. All the submodules are landed except for the minor rust-phf update.

r? @larsbergstrom

You specify a 32bit build by setting --target on configure.
metajack added a commit that referenced this pull request Aug 15, 2014
Enable 32bit builds.
@metajack metajack merged commit f300e14 into servo:master Aug 15, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@metajack metajack deleted the metajack:build-32bit branch Aug 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.