Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial ShadowDOM support #22743

Merged
merged 83 commits into from Apr 29, 2019
Merged

Partial ShadowDOM support #22743

merged 83 commits into from Apr 29, 2019

Commits on Apr 26, 2019

  1. DocumentOrShadowRoot mixin

    @ferjm
    ferjm committed Apr 26, 2019
    cbcf21c

  2. ShadowRoot interface

    @ferjm
    ferjm committed Apr 26, 2019
    18ae0fc

  3. Partial ShadowRoot implementation of DocumentOrShadowRoot

    @ferjm
    ferjm committed Apr 26, 2019
    4304ee2

  4. Element attachShadow implementation

    @ferjm
    ferjm committed Apr 26, 2019
    569b4fc

  5. IS_IN_SHADOW_TREE flag

    @ferjm
    ferjm committed Apr 26, 2019
    9022bd3

  6. Node shadow root owner

    @ferjm
    ferjm committed Apr 26, 2019
    091fcbe

  7. Expose Element.AttachShadow under dom.shadowdom.enabled pref

    @ferjm
    ferjm committed Apr 26, 2019
    ffdc9d2

  8. Test DOM isolation for shadow trees

    @ferjm
    ferjm committed Apr 26, 2019
    f3e7073

  9. Unify DocumentOrShadowRoot implementation

    @ferjm
    ferjm committed Apr 26, 2019
    4897584

  10. Implement shadow-including root, set node as in doc when connected. M… 

    …akes JS work in shadow trees
    @ferjm
    ferjm committed Apr 26, 2019
    640fc04

  11. Add is_connected flag to node and use it to replace most uses of is_i… 

    …n_doc
    @ferjm
    ferjm committed Apr 26, 2019
    441357b

  12. Node retargeting algorithm

    @ferjm
    ferjm committed Apr 26, 2019
    ea69bbc

  13. Make note_dirty_descendants jump around shadow roots

    @ferjm
    ferjm committed Apr 26, 2019
    4740ce5

  14. Set connected flag not only on elements

    @ferjm
    ferjm committed Apr 26, 2019
    df81deb

  15. Bind/unbind shadow host children to/from tree

    @ferjm
    ferjm committed Apr 26, 2019
    1b03635

  16. Introduce concept of composed parent node

    @ferjm
    ferjm committed Apr 26, 2019
    c48ad0f

  17. Do not care about shadow roots when getting root element

    @ferjm
    ferjm committed Apr 26, 2019
    d6ddb08

  18. Throw NotSupported when trying to deep clone a shadow root

    @ferjm
    ferjm committed Apr 26, 2019
    6a85409

  19. Throw when trying to import or adopt a shadow root

    @ferjm
    ferjm committed Apr 26, 2019
    f6ba165

  20. Implement concept of shadow including tree order

    @ferjm
    ferjm committed Apr 26, 2019
    2e5c058

  21. Always get browsing context from document

    @ferjm
    ferjm committed Apr 26, 2019
    be06f1e

  22. First bits of shadow dom layout

    @ferjm
    ferjm committed Apr 26, 2019
    7c9e8aa

  23. Adapt traversals for shadow dom

    @ferjm
    ferjm committed Apr 26, 2019
    d2e1a3a

  24. Move stylesheets related code to DocumentOrShadowRoot

    @ferjm
    ferjm committed Apr 26, 2019
    0d6bd24

  25. ShadowRoot stylesheet list

    @ferjm
    ferjm committed Apr 26, 2019
    3bb50cc

  26. Remove stylesheets ownership from DocumentOrShadowRoot

    @ferjm
    ferjm committed Apr 26, 2019
    23b92d5

  27. Implement TShadowRoot::style_data

    @ferjm
    ferjm committed Apr 26, 2019
    e9f0e76

  28. Expose a way to flush shadow root stylesheets from layout

    @ferjm
    ferjm committed Apr 26, 2019
    cd07574

  29. Register/unregister shadow roots in documents when they are connected

    @ferjm
    ferjm committed Apr 26, 2019
    18c1b8f

  30. Invalidate and flush shadow tree stylesheets where needed

    @ferjm
    ferjm committed Apr 26, 2019
    519cc2c

  31. Do not add shadow tree styles to stylist

    @ferjm
    ferjm committed Apr 26, 2019
    47872cd

  32. Fix Document.Element(s)FromPoint

    @ferjm
    ferjm committed Apr 26, 2019
    8641866

  33. Retarget result of shadowRoot.element(s)FromPoint

    @ferjm
    ferjm committed Apr 26, 2019
    07e2f41

  34. Return composed parent node. Fixes style sharing panics

    @ferjm
    ferjm committed Apr 26, 2019
    efce282

  35. Update test expectations and whitelist ShadowRoot interface

    @ferjm
    ferjm committed Apr 26, 2019
    f097233

  36. Update size of tests with shadow root size

    @ferjm
    ferjm committed Apr 26, 2019
    067acdf

  37. Fix formatting issues

    @ferjm
    ferjm committed Apr 26, 2019
    2515966

  38. Shadow DOM layout and style reftest

    @ferjm
    ferjm committed Apr 26, 2019
    0d2f65b

  39. Fix the way the IS_CONNECTED flag is set

    @ferjm
    ferjm committed Apr 26, 2019
    e66438d

  40. Do not set dirty out-of-doc nodes

    @ferjm
    ferjm committed Apr 26, 2019
    d7b6a6f

  41. Remove IS_CONNECTED flag when node is removed from the doc

    @ferjm
    ferjm committed Apr 26, 2019
    39c96ac

  42. Update expectations for cssom tests

    @ferjm
    ferjm committed Apr 26, 2019
    57fa6b1

  43. Derive PartialEq for ServoShadowRoot

    @ferjm
    ferjm committed Apr 26, 2019
    00178af

  44. Minor layout thread cleanups: 

    - lifetime naming
- unrequired reference removal
- containing_shadow_host getter simplification
- use stylist.device getter where possible
    @ferjm
    ferjm committed Apr 26, 2019
    a841c71

  45. Flush shadow roots stylesheets only if they changed

    @ferjm
    ferjm committed Apr 26, 2019
    2674a3e

  46. Introduce ShadowIncluding enum for tree traversals

    @ferjm
    ferjm committed Apr 26, 2019
    3ccd622

  47. Make StyleSheetListOwner implement JSTraceable

    @ferjm
    ferjm committed Apr 26, 2019
    3dd3815

  48. Add invalidate_stylesheets to StyleSheetsListOwner trait

    @ferjm
    ferjm committed Apr 26, 2019
    d77b9c6

  49. Relax attachShadow restrictions for user agent widgets

    @ferjm
    ferjm committed Apr 26, 2019
    67c90a0

  50. Make ServoShadowRoot.flush_stylesheets unsafe

    @ferjm
    ferjm committed Apr 26, 2019
    3e63655

  51. Do not send RemoveStyleSheet message for shadow roots

    @ferjm
    ferjm committed Apr 26, 2019
    3e53962

  52. Make StylesheetSet an enum instead of a trait object

    @ferjm
    ferjm committed Apr 26, 2019
    8b353ee

  53. Make StyleSheetListOwner an enum instead of a trait object

    @ferjm
    ferjm committed Apr 26, 2019
    2350f0e

  54. Derive MallocSizeOf for QuirksMode

    @ferjm
    ferjm committed Apr 26, 2019
    5426996

  55. Do not store composed parent node

    @ferjm
    ferjm committed Apr 26, 2019
    ea1fe15

  56. Document owner_shadow_root

    @ferjm
    ferjm committed Apr 26, 2019
    ccf8a43

  57. Register named elements in either the document or shadow tree

    @ferjm
    ferjm committed Apr 26, 2019
    740aae0

  58. Introduce BindContext with in_doc and connected flags 

    Fix some is_in_doc -> is_connected mistakes
    @ferjm
    ferjm committed Apr 26, 2019
    813b242

  59. Introduce NodeRareData and ElementRareData

    @ferjm
    ferjm committed Apr 26, 2019
    6af4729

  60. Move mutation observers list to NodeRareData

    @ferjm
    ferjm committed Apr 26, 2019
    a9019da

  61. Add custom elements related stuff into ElementRareData

    @ferjm
    ferjm committed Apr 26, 2019
    c75da61

  62. Update size of tests after *RareData changes

    @ferjm
    ferjm committed Apr 26, 2019
    1427c43

  63. Set IS_CONNECTED flag on host and children instead of on containing s… 

    …hadow root
    @ferjm
    ferjm committed Apr 26, 2019
    b8925a0

  64. Tweak list of shadow roots attached to doc

    @ferjm
    ferjm committed Apr 26, 2019
    0313e38

  65. Minor tweaks: rename composed_parent_node_ref, remove or update outda… 

    …ted comments...
    @ferjm
    ferjm committed Apr 26, 2019
    bdd2f32

  66. Revert style/dom_apis changes

    @ferjm
    ferjm committed Apr 26, 2019
    5be6779

  67. Move is_connected function from style to layout, where it is used

    @ferjm
    ferjm committed Apr 26, 2019
    5a165c6

  68. Make devtools find node by unique id function include shadow trees

    @ferjm
    ferjm committed Apr 26, 2019
    efbfc0f

  69. Revert changes in sheet_set_methods macro

    @ferjm
    ferjm committed Apr 26, 2019
    0ca4792

  70. Merge Node::shadow_including_inclusive_ancestors into inclusive_ances… 

    …tors
    @ferjm
    ferjm committed Apr 26, 2019
    8eba587

  71. Optimize Node::GetRootNode

    @ferjm
    ferjm committed Apr 26, 2019
    890297e

  72. Update tests manifest

    @ferjm
    ferjm committed Apr 26, 2019
    f606963

  73. Make Node and Element rare_data an Option

    @ferjm
    ferjm committed Apr 26, 2019
    6bf1ca2

  74. Set dirty descendants if node is connected

    @ferjm
    ferjm committed Apr 26, 2019
    59c634b

  75. Add dom.shadowdom.enabled to preferences list

    @ferjm
    ferjm committed Apr 26, 2019
    ccc4f7c

  76. Set dirty descendants flag only for elements

    @ferjm
    ferjm committed Apr 26, 2019
    3f312f7

  77. Revert unnecessary format changes

    @ferjm
    ferjm committed Apr 26, 2019
    9df1c2f

  78. Rename StylesheetSet to StylesheetSetRef

    @ferjm
    ferjm committed Apr 26, 2019
    e4f34fd

  79. Rename shadow_root_from_node to containing_shadow_root

    @ferjm
    ferjm committed Apr 26, 2019
    9d52fef

  80. Move StylesheetSetRef to script

    @ferjm
    ferjm committed Apr 26, 2019
    d0b2e82

  81. Do not lazy initialize RareData on its getters

    @ferjm
    ferjm committed Apr 26, 2019
    9b2eb77

Commits on Apr 29, 2019

  1. Final nits; fix custom elements rare data usage; s/owner_s_r/containi… 

    …ng_s_r

Clarify special case for containing_shadow_root and add it to layout
accessor
    @ferjm
    ferjm committed Apr 29, 2019
    68bee1c

  2. Set self as containing_shadow_root for shadow roots

    @ferjm
    ferjm committed Apr 29, 2019
    Loading status checks…
    37e88e7
You can’t perform that action at this time.