Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCorrect the GStreamer PATH for windows #22751
Closed
Conversation
highfive
commented
Jan 23, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon. |
|
Thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 23, 2019
…r=ferjm Correct the GStreamer PATH for windows <!-- Please describe your changes on the following line: --> Just like what I said, `LNK1181` error when building `servo`: #22737 (comment) The `gstplayer-1.0.lib` is not found, it located in `C:\gstreamer\1.0\x86_64\lib`, not `C:\gstreamer\1.0\x86_64\bin` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [X] `./mach build -r` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] These changes do not require tests because it's `README.md` <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22751) <!-- Reviewable:end -->
|
|
|
This got merged, but it looks like a github notification was missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
learning commentedJan 23, 2019
•
edited by SimonSapin
Just like what I said,
LNK1181error when buildingservo:#22737 (comment)
The
gstplayer-1.0.libis not found, it located inC:\gstreamer\1.0\x86_64\lib, notC:\gstreamer\1.0\x86_64\bin./mach build -ddoes not report any errors./mach build -rdoes not report any errors./mach test-tidydoes not report any errorsREADME.mdThis change is