Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a threadpool for fetch #22769

Merged

Conversation

Projects
None yet
6 participants
@gterzian
Copy link
Collaborator

commented Jan 27, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22768 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jan 27, 2019

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/Cargo.toml, components/net/resource_thread.rs

@gterzian gterzian force-pushed the gterzian:use_thread_pool_in_resource_thread branch from fb6588d to 4309655 Jan 27, 2019

@gterzian gterzian force-pushed the gterzian:use_thread_pool_in_resource_thread branch 4 times, most recently from 521758e to e8ed65c Jan 27, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

☔️ The latest upstream changes (presumably #22786) made this pull request unmergeable. Please resolve the merge conflicts.

@gterzian gterzian force-pushed the gterzian:use_thread_pool_in_resource_thread branch from e8ed65c to e25bbd7 Feb 12, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

☔️ The latest upstream changes (presumably #22521) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Oops, awkward. r=me if this gets rebased.

@gterzian gterzian force-pushed the gterzian:use_thread_pool_in_resource_thread branch 2 times, most recently from ffcb4e6 to c7c8804 Apr 12, 2019

@gterzian

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

Ok, rebased @jdm

@@ -13052,6 +13052,12 @@
{}
]
],
"mozilla/fetch_cannot_overwhelm_system.window.js": [
[
"/_mozilla/mozilla/fetch_cannot_overwhelm_system.window.html",

This comment has been minimized.

Copy link
@jdm

jdm Apr 12, 2019

Member

Could you run ./Mach update-manifest?

This comment has been minimized.

Copy link
@gterzian

gterzian Apr 16, 2019

Author Collaborator

I'm looking into it, it seems to not have any effect...

This comment has been minimized.

Copy link
@jdm

jdm Apr 16, 2019

Member

Try manually removing the /_mozilla/ prefix, in that case.

This comment has been minimized.

Copy link
@gterzian

gterzian Apr 16, 2019

Author Collaborator

Ok, I've filed #23214

@gterzian gterzian force-pushed the gterzian:use_thread_pool_in_resource_thread branch from c7c8804 to d0e1a5e Apr 16, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Looks like one more ./mach fmt is required.
@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

✌️ @gterzian can now approve this pull request

@gterzian gterzian force-pushed the gterzian:use_thread_pool_in_resource_thread branch from d0e1a5e to 1e40c64 Apr 16, 2019

@gterzian

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 16, 2019

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

📌 Commit 1e40c64 has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Apr 16, 2019

bors-servo added a commit that referenced this pull request Apr 18, 2019

Auto merge of #22769 - gterzian:use_thread_pool_in_resource_thread, r…
…=<try>

Use a threadpool for fetch

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22768 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22769)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

💔 Test failed - linux-rel-css

@gterzian gterzian force-pushed the gterzian:use_thread_pool_in_resource_thread branch from a1af9ea to 1745ad4 Apr 18, 2019

@gterzian

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 18, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

⌛️ Trying commit 1745ad4 with merge 4f0fa16...

bors-servo added a commit that referenced this pull request Apr 18, 2019

Auto merge of #22769 - gterzian:use_thread_pool_in_resource_thread, r…
…=<try>

Use a threadpool for fetch

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22768 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22769)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@bors-servo r=nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

📌 Commit 1745ad4 has been approved by nox

@highfive highfive assigned nox and unassigned jdm Apr 18, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

⌛️ Testing commit 1745ad4 with merge d6a36da...

bors-servo added a commit that referenced this pull request Apr 18, 2019

Auto merge of #22769 - gterzian:use_thread_pool_in_resource_thread, r…
…=nox

Use a threadpool for fetch

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22768 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22769)
<!-- Reviewable:end -->

@gterzian gterzian force-pushed the gterzian:use_thread_pool_in_resource_thread branch from 1745ad4 to c52cfda Apr 18, 2019

@gterzian

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 19, 2019

@bors-servo r=nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

📌 Commit c52cfda has been approved by nox

bors-servo added a commit that referenced this pull request Apr 19, 2019

Auto merge of #22769 - gterzian:use_thread_pool_in_resource_thread, r…
…=nox

Use a threadpool for fetch

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22768 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22769)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

⌛️ Testing commit c52cfda with merge c449cbb...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

@bors-servo bors-servo merged commit c52cfda into servo:master Apr 19, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.