New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade brotli dependency. #22776

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
5 participants
@jdm
Copy link
Member

jdm commented Jan 29, 2019

This incorporates a fix for streaming decoding that drops content when a WouldBlock error is encountered.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22749 and fix #22717 and fix (maybe) #22712.
  • There are tests for these changes

This change is Reviewable

@emilio

This comment has been minimized.

Copy link
Member

emilio commented Jan 29, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 29, 2019

📌 Commit f3f20e6 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 29, 2019

⌛️ Testing commit f3f20e6 with merge d837767...

bors-servo added a commit that referenced this pull request Jan 29, 2019

Auto merge of #22776 - jdm:brotli-upgrade, r=emilio
Upgrade brotli dependency.

This incorporates a fix for streaming decoding that drops content when a WouldBlock error is encountered.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22749 and fix #22717 and fix (maybe) #22712.
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22776)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 29, 2019

@bors-servo bors-servo merged commit f3f20e6 into servo:master Jan 29, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment