Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In BC event-loop, only run tasks related to fully-active documents #22802

Merged

Conversation

Projects
None yet
8 participants
@gterzian
Copy link
Collaborator

gterzian commented Feb 1, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22792 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Feb 1, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/script_thread.rs, components/script/task_queue.rs, components/script/dom/serviceworkerglobalscope.rs, components/script/dom/dedicatedworkerglobalscope.rs
  • @KiChjang: components/script/script_thread.rs, components/script/task_queue.rs, components/script/dom/serviceworkerglobalscope.rs, components/script/dom/dedicatedworkerglobalscope.rs
@highfive

This comment has been minimized.

Copy link

highfive commented Feb 1, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch 2 times, most recently from c1dfb66 to 6d0e5c7 Feb 1, 2019

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from 6d0e5c7 to 664bb6d Feb 3, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from 664bb6d to c613e22 Feb 3, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch 2 times, most recently from 5e88923 to df13e49 Feb 3, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

1 similar comment
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from df13e49 to b42478c Feb 3, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from b42478c to 212fec2 Feb 3, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from 212fec2 to c715460 Feb 3, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian changed the title [WIP] in BC event-loop, only run tasks related to fully-active documents In BC event-loop, only run tasks related to fully-active documents Feb 3, 2019

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch 2 times, most recently from 80bcd83 to 277828d Feb 3, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

1 similar comment
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from 277828d to 1790924 Feb 4, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Feb 4, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from 1790924 to 77fdccb Feb 4, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 5, 2019

⌛️ Trying commit 0ae51fb with merge 6371dc9...

bors-servo added a commit that referenced this pull request Mar 5, 2019

Auto merge of #22802 - gterzian:only_run_tasks_for_fully_active_docs,…
… r=<try>

In BC event-loop, only run tasks related to fully-active documents

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22792 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22802)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 5, 2019

💔 Test failed - linux-rel-css

@gterzian

This comment has been minimized.

Copy link
Collaborator Author

gterzian commented Mar 5, 2019

CRASH [expected TIMEOUT] /html/webappapis/dynamic-markup-insertion/opening-the-input-stream/tasks.window.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 18.3.0-devel
  │ Spurious wake-up of the event-loop, task-queue has no tasks available: () (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }, at src/libcore/result.rs:997)
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Tasks for documents that are not fully active are stored, and run when the documents becomes fully-active", 
    "test": "/html/webappapis/scripting/event-loops/fully_active_document.window.html", 
    "line": 199662, 
    "action": "test_result", 
    "expected": "FAIL"
}

Will look into...

@highfive highfive removed the S-tests-failed label Mar 5, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Mar 5, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

2 similar comments
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Mar 5, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Mar 5, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from d078652 to d9e90f1 Mar 5, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Mar 5, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian

This comment has been minimized.

Copy link
Collaborator Author

gterzian commented Mar 6, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 6, 2019

⌛️ Trying commit d9e90f1 with merge c635132...

bors-servo added a commit that referenced this pull request Mar 6, 2019

Auto merge of #22802 - gterzian:only_run_tasks_for_fully_active_docs,…
… r=<try>

In BC event-loop, only run tasks related to fully-active documents

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22792 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22802)
<!-- Reviewable:end -->
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Mar 6, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian gterzian force-pushed the gterzian:only_run_tasks_for_fully_active_docs branch from f37c59b to ecfb9c6 Mar 6, 2019

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Mar 6, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15224.

@gterzian

This comment has been minimized.

Copy link
Collaborator Author

gterzian commented Mar 6, 2019

@nox Ok I fixed the previous problems, and updated the expectations to pass for /workers/semantics/navigation/002.html. The test I wrote, and initially expected to fail, now passes, although I am not sure why. From print statements I can tell that the logic still works as expected, did anything change recently about how we close pipelines?

@nox

This comment has been minimized.

Copy link
Member

nox commented Mar 11, 2019

Great work for /workers/semantics/navigation/002.html!

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 11, 2019

📌 Commit ecfb9c6 has been approved by nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 11, 2019

⌛️ Testing commit ecfb9c6 with merge f2ea73f...

bors-servo added a commit that referenced this pull request Mar 11, 2019

Auto merge of #22802 - gterzian:only_run_tasks_for_fully_active_docs,…
… r=nox

In BC event-loop, only run tasks related to fully-active documents

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22792 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22802)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 11, 2019

@bors-servo bors-servo merged commit ecfb9c6 into servo:master Mar 11, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Mar 11, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1552326896434.

@gterzian gterzian deleted the gterzian:only_run_tasks_for_fully_active_docs branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.