Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid locking network timing data unnecessarily. #22808

Merged
merged 1 commit into from Mar 7, 2019
Merged

Avoid locking network timing data unnecessarily. #22808

merged 1 commit into from Mar 7, 2019

Conversation

@jdm
Copy link
Member

jdm commented Feb 1, 2019 •
edited by SimonSapin

This change is Reviewable
@jdm
Avoid locking network timing data unnecessarily.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
086d2f4
@highfive
Copy link

highfive commented Feb 1, 2019

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Feb 1, 2019

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Feb 11, 2019

Review ping @asajeffrey
@jdm
Copy link
Member Author

jdm commented Mar 1, 2019

Review ping v2 @asajeffrey
@asajeffrey
Copy link
Member

asajeffrey commented Mar 6, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2019

📌 Commit 086d2f4 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2019

⌛ Testing commit 086d2f4 with merge 008368f...
bors-servo added a commit that referenced this pull request Mar 6, 2019
@bors-servo
Auto merge of #22808 - servo:jdm-patch-10, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
008368f 
Avoid locking network timing data unnecessarily.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22808)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

💔 Test failed - mac-rel-wpt3
@CYBAI
Copy link
Collaborator

CYBAI commented Mar 7, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

⚡ Previous build results for android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4, magicleap, status-taskcluster are reusable. Rebuilding only mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: asajeffrey
Pushing 008368f to master...
@bors-servo bors-servo merged commit 086d2f4 into master Mar 7, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-10 branch Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @asajeffrey @bors-servo @CYBAI
You can’t perform that action at this time.