Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Add more missing dependencies #22811

Merged
merged 2 commits into from Feb 2, 2019
Merged

Windows: Add more missing dependencies #22811

merged 2 commits into from Feb 2, 2019

Conversation

@UK992
Copy link
Contributor

UK992 commented Feb 2, 2019 •
edited by atouchet

From #21968 (comment)

This change is Reviewable
UK992 added 2 commits Feb 2, 2019
@UK992
Alphabetically sort GStreamer dlls
ac8ac39
@UK992
Add more GStreamer DLLs
Loading status checks…
4c23622
@highfive
Copy link

highfive commented Feb 2, 2019

Heads up! This PR modifies the following files:
@jdm
Copy link
Member

jdm commented Feb 2, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2019

📌 Commit 4c23622 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2019

⌛ Testing commit 4c23622 with merge 007333e...
bors-servo added a commit that referenced this pull request Feb 2, 2019
@bors-servo
Auto merge of #22811 - UK992:mach-package-2, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
007333e 
Windows: Add more missing dependencies

From #21968 (comment)
r? @jdm

cc @atouchet

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22811)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2019

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Feb 2, 2019 •
edited

@bors-servo retry
Network
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2019

⚡ Previous build results for android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-wpt1, magicleap, status-taskcluster are reusable. Rebuilding only mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 007333e to master...
@bors-servo bors-servo merged commit 4c23622 into servo:master Feb 2, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Feb 3, 2019
Open
Closed
@UK992 UK992 deleted the UK992:mach-package-2 branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@UK992 @highfive @jdm @bors-servo
You can’t perform that action at this time.