Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout fullscreen top layer #22825

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
5 participants
@asajeffrey
Copy link
Member

asajeffrey commented Feb 5, 2019

Implement the fullscreen top layer described at https://fullscreen.spec.whatwg.org/#top-layer


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes OR

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Feb 5, 2019

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs
  • @emilio: components/layout/display_list/items.rs, components/style/properties/longhands/box.mako.rs, components/layout/display_list/builder.rs, components/style/properties/properties.mako.rs
@asajeffrey

This comment has been minimized.

Copy link
Member Author

asajeffrey commented Feb 5, 2019

This PR gets its tests from PR #22809, so we should land that PR first.

asajeffrey added a commit to asajeffrey/servo that referenced this pull request Feb 5, 2019

@asajeffrey asajeffrey force-pushed the asajeffrey:layout-fullscreen-top-layer branch from 4c9f707 to 386c0f8 Feb 6, 2019

@asajeffrey

This comment has been minimized.

Copy link
Member Author

asajeffrey commented Feb 6, 2019

Rebased. Now that #22809 has landed, this is ready for review.

asajeffrey added a commit to asajeffrey/servo that referenced this pull request Feb 6, 2019

@asajeffrey asajeffrey referenced this pull request Feb 6, 2019

Open

Add test infrastructure for WebVR reftests #22840

4 of 4 tasks complete
@jdm

This comment has been minimized.

Copy link
Member

jdm commented Feb 6, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 6, 2019

📌 Commit 386c0f8 has been approved by jdm

@highfive highfive assigned jdm and unassigned emilio Feb 6, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 6, 2019

⌛️ Testing commit 386c0f8 with merge 73ff999...

bors-servo added a commit that referenced this pull request Feb 6, 2019

Auto merge of #22825 - asajeffrey:layout-fullscreen-top-layer, r=jdm
Layout fullscreen top layer

<!-- Please describe your changes on the following line: -->

Implement the fullscreen top layer described at https://fullscreen.spec.whatwg.org/#top-layer

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22825)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 6, 2019

@bors-servo bors-servo merged commit 386c0f8 into servo:master Feb 6, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.