Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for contentDocument behaviour during parsing #22841

Merged
merged 1 commit into from Feb 11, 2019
Merged

Add test for contentDocument behaviour during parsing #22841

merged 1 commit into from Feb 11, 2019

Conversation

@jdm
Copy link
Member

jdm commented Feb 6, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22503
  • There are tests for these changes

This change is Reviewable
@jdm
Verify that contentDocument is updated during nested browsing context…
Loading status checks…
3315d94 
… document parsing.
@jdm jdm force-pushed the jdm:iframe-nav-test branch from 434deff to 3315d94 Feb 6, 2019
@servo-wpt-sync servo-wpt-sync mentioned this pull request Feb 6, 2019
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Feb 6, 2019

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#15268.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Feb 6, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1549489208181.
@jdm
Copy link
Member Author

jdm commented Feb 11, 2019

r? @nox
@highfive highfive assigned nox and unassigned avadacatavra Feb 11, 2019
@nox
Copy link
Member

nox commented Feb 11, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

📌 Commit 3315d94 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

⌛ Testing commit 3315d94 with merge 9358b6a...
bors-servo added a commit that referenced this pull request Feb 11, 2019
@bors-servo
Auto merge of #22841 - jdm:iframe-nav-test, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9358b6a 
Add test for contentDocument behaviour during parsing

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22503
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: nox
Pushing 9358b6a to master...
@bors-servo bors-servo merged commit 3315d94 into servo:master Feb 11, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@CYBAI
Copy link
Collaborator

CYBAI commented Feb 12, 2019

Hmm, not sure if servo/saltfs#943 has been deployed ? I saw the labels in web-platform-tests/wpt#15268 were all deleted 😭
@jdm
Copy link
Member Author

jdm commented Feb 12, 2019

It has not been deployed yet, as demonstrated by the S-needs-deploy label.
@CYBAI
Copy link
Collaborator

CYBAI commented Feb 12, 2019

@jdm Oh! Thanks! Didn't notice the label 😄 Will keep an eye on this issue 👀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Iframe's contentDocument is incorrect before load event is fired
7 participants
@jdm @servo-wpt-sync @nox @bors-servo @CYBAI @highfive @avadacatavra
You can’t perform that action at this time.