Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate simpleservo.h #22844

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
5 participants
@paulrouget
Copy link
Contributor

paulrouget commented Feb 7, 2019

Fix #22834

Waiting on eqrion/cbindgen#271


This change is Reviewable

@paulrouget paulrouget force-pushed the paulrouget:capi-header branch from f0a91b8 to 792ed8a Feb 15, 2019

@paulrouget paulrouget changed the title [WIP] Generate simpleservo.h Generate simpleservo.h Feb 15, 2019

@paulrouget

This comment has been minimized.

Copy link
Contributor Author

paulrouget commented Feb 15, 2019

@paulrouget paulrouget assigned SimonSapin and unassigned Manishearth Feb 15, 2019

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Feb 15, 2019

@bors-servo r+

Looks good. It might be good to have an example C program that uses this header, and test on CI that it can link successfully. But that can be added later.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 15, 2019

📌 Commit 792ed8a has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 15, 2019

⌛️ Testing commit 792ed8a with merge 710271f...

bors-servo added a commit that referenced this pull request Feb 15, 2019

Auto merge of #22844 - paulrouget:capi-header, r=SimonSapin
Generate simpleservo.h

Fix #22834

Waiting on eqrion/cbindgen#271

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22844)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 15, 2019

@bors-servo bors-servo merged commit 792ed8a into servo:master Feb 15, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.