Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the target attribute for HTMLAreaElement #22850

Merged
merged 1 commit into from Feb 11, 2019
Merged

Implement the target attribute for HTMLAreaElement #22850

merged 1 commit into from Feb 11, 2019

Conversation

@georgeroman
Copy link
Contributor

georgeroman commented Feb 8, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22515

This change is Reviewable
@highfive
Copy link

highfive commented Feb 8, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlareaelement.rs, components/script/dom/webidls/HTMLAreaElement.webidl
  • @KiChjang: components/script/dom/htmlareaelement.rs, components/script/dom/webidls/HTMLAreaElement.webidl
@highfive
Copy link

highfive commented Feb 8, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@georgeroman georgeroman mentioned this pull request Feb 8, 2019
Closed
@jdm
Copy link
Member

jdm commented Feb 8, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Feb 8, 2019
@bors-servo
Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a6b3213 
…ttribute, r=<try>

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2019

⌛ Trying commit e4ebeda with merge a6b3213...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2019

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Feb 8, 2019 

  ▶ Unexpected subtest result in /html/dom/interfaces.https.html?include=HTML.*:
  └ PASS [expected FAIL] HTMLAreaElement interface: attribute target

  ▶ Unexpected subtest result in /html/dom/interfaces.https.html?include=HTML.*:
  └ PASS [expected FAIL] HTMLAreaElement interface: document.createElement("area") must inherit property "target" with the proper type
@highfive highfive removed the S-tests-failed label Feb 8, 2019
@ferjm
Copy link
Member

ferjm commented Feb 11, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

📌 Commit 9389edc has been approved by ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

⌛ Testing commit 9389edc with merge 921ce41...
bors-servo added a commit that referenced this pull request Feb 11, 2019
@bors-servo
Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
921ce41 
…ttribute, r=ferjm

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

💔 Test failed - linux-rel-wpt
@georgeroman
Implement the target attribute for HTMLAreaElement
Loading status checks…
90b5d0d
@ferjm
Copy link
Member

ferjm commented Feb 11, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Feb 11, 2019
@bors-servo
Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3756efe 
…ttribute, r=<try>

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

⌛ Trying commit 90b5d0d with merge 3756efe...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@ferjm
Copy link
Member

ferjm commented Feb 11, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

📌 Commit 90b5d0d has been approved by ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

⌛ Testing commit 90b5d0d with merge 7ed6b9d...
bors-servo added a commit that referenced this pull request Feb 11, 2019
@bors-servo
Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7ed6b9d 
…ttribute, r=ferjm

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: ferjm
Pushing 7ed6b9d to master...
@bors-servo bors-servo merged commit 90b5d0d into servo:master Feb 11, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ferjm ferjm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement browsing context targetting for HTMLAreaElement
5 participants
@georgeroman @highfive @jdm @bors-servo @ferjm
You can’t perform that action at this time.