Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the target attribute for HTMLAreaElement #22850

Merged
merged 1 commit into from Feb 11, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -299,6 +299,12 @@ impl VirtualMethods for HTMLAreaElement {
}

impl HTMLAreaElementMethods for HTMLAreaElement {
// https://html.spec.whatwg.org/multipage/#attr-hyperlink-target
make_getter!(Target, "target");

// https://html.spec.whatwg.org/multipage/#attr-hyperlink-target
make_setter!(SetTarget, "target");

// https://html.spec.whatwg.org/multipage/#dom-area-rellist
fn RelList(&self) -> DomRoot<DOMTokenList> {
self.rel_list
@@ -11,8 +11,8 @@ interface HTMLAreaElement : HTMLElement {
// attribute DOMString coords;
// [CEReactions]
// attribute DOMString shape;
// [CEReactions]
// attribute DOMString target;
[CEReactions]
attribute DOMString target;
// [CEReactions]
// attribute DOMString download;
// [CEReactions]
@@ -1898,9 +1898,6 @@
[HTMLAreaElement interface: attribute shape]
expected: FAIL

[HTMLAreaElement interface: attribute target]
expected: FAIL

[HTMLAreaElement interface: attribute download]
expected: FAIL

@@ -1964,9 +1961,6 @@
[HTMLAreaElement interface: document.createElement("area") must inherit property "shape" with the proper type]
expected: FAIL

[HTMLAreaElement interface: document.createElement("area") must inherit property "target" with the proper type]
expected: FAIL

[HTMLAreaElement interface: document.createElement("area") must inherit property "download" with the proper type]
expected: FAIL

@@ -6912,9 +6906,6 @@
[HTMLAreaElement interface: attribute shape]
expected: FAIL

[HTMLAreaElement interface: attribute target]
expected: FAIL

[HTMLAreaElement interface: attribute download]
expected: FAIL

@@ -6978,9 +6969,6 @@
[HTMLAreaElement interface: document.createElement("area") must inherit property "shape" with the proper type]
expected: FAIL

[HTMLAreaElement interface: document.createElement("area") must inherit property "target" with the proper type]
expected: FAIL

[HTMLAreaElement interface: document.createElement("area") must inherit property "download" with the proper type]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.