Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional ANGLE support to glutin port #22856

Merged
merged 3 commits into from May 10, 2019
Merged

Add optional ANGLE support to glutin port #22856

merged 3 commits into from May 10, 2019

Conversation

@jdm
Copy link
Member

jdm commented Feb 8, 2019 •
edited

Supporting ANGLE in Servo has two important benefits:

  • we can actually run Servo instances on our Windows CI machines, which gives us more confidence that we're not breaking it
  • we can continue to use OpenGL on devices like the Hololens, rather than creating platform-specific graphical backends

This change is Reviewable
@highfive
Copy link

highfive commented Feb 8, 2019

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/testing_commands.py
  • @paulrouget: ports/servo/glutin_app/egl.rs, ports/servo/glutin_app/window.rs, ports/servo/glutin_app/mod.rs, ports/servo/Cargo.toml
@highfive
Copy link

highfive commented Feb 8, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm
Copy link
Member Author

jdm commented Feb 8, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2019

⌛ Trying commit 7e36817 with merge 63d72b9...
bors-servo added a commit that referenced this pull request Feb 8, 2019
@bors-servo
Auto merge of #22856 - jdm:angle, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
63d72b9 
WIP add angle support

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22856)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Feb 8, 2019

@bors-servo try=windows
@jdm jdm force-pushed the jdm:angle branch from 9d5d67f to 99b5242 Feb 8, 2019
@jdm
Copy link
Member Author

jdm commented Feb 8, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2019

⌛ Trying commit 99b5242 with merge 6fce713...
bors-servo added a commit that referenced this pull request Feb 9, 2019
@bors-servo
Auto merge of #22856 - jdm:angle, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6fce713 
WIP add angle support

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22856)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:angle branch from 99b5242 to c36cb62 Feb 9, 2019
@highfive highfive removed the S-tests-failed label Feb 9, 2019
@jdm
Copy link
Member Author

jdm commented Feb 9, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2019

⌛ Trying commit c36cb62 with merge 91c588e...
bors-servo added a commit that referenced this pull request Feb 9, 2019
@bors-servo
Auto merge of #22856 - jdm:angle, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91c588e 
WIP add angle support

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22856)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:angle branch from c36cb62 to 211138d Feb 9, 2019
@highfive highfive removed the S-tests-failed label Feb 9, 2019
@jdm
Copy link
Member Author

jdm commented Feb 9, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2019

⌛ Trying commit 211138d with merge c5ecb00...
bors-servo added a commit that referenced this pull request Feb 9, 2019
@bors-servo
Auto merge of #22856 - jdm:angle, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c5ecb00 
WIP add angle support

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22856)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2019

💔 Test failed - status-taskcluster
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2019

⌛ Testing commit a690d6f with merge 5fff2a8...
bors-servo added a commit that referenced this pull request May 9, 2019
@bors-servo
Auto merge of #22856 - jdm:angle, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5fff2a8 
Add optional ANGLE support to glutin port

Supporting ANGLE in Servo has two important benefits:
* we can actually run Servo instances on our Windows CI machines, which gives us more confidence that we're not breaking it
* we can continue to use OpenGL on devices like the Hololens, rather than creating platform-specific graphical backends

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22856)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit a690d6f with merge 4d8be3e...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #22856 - jdm:angle, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4d8be3e 
Add optional ANGLE support to glutin port

Supporting ANGLE in Servo has two important benefits:
* we can actually run Servo instances on our Windows CI machines, which gives us more confidence that we're not breaking it
* we can continue to use OpenGL on devices like the Hololens, rather than creating platform-specific graphical backends

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22856)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo r-
@jdm jdm closed this May 10, 2019
UWP port automation moved this from Probably unnecessary to Done May 10, 2019
@jdm jdm reopened this May 10, 2019
UWP port automation moved this from Done to In progress May 10, 2019
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo r=paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

📌 Commit a690d6f has been approved by paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit a690d6f with merge 7304606...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #22856 - jdm:angle, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7304606 
Add optional ANGLE support to glutin port

Supporting ANGLE in Servo has two important benefits:
* we can actually run Servo instances on our Windows CI machines, which gives us more confidence that we're not breaking it
* we can continue to use OpenGL on devices like the Hololens, rather than creating platform-specific graphical backends

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22856)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit a690d6f with merge b1b47d8...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #22856 - jdm:angle, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b1b47d8 
Add optional ANGLE support to glutin port

Supporting ANGLE in Servo has two important benefits:
* we can actually run Servo instances on our Windows CI machines, which gives us more confidence that we're not breaking it
* we can continue to use OpenGL on devices like the Hololens, rather than creating platform-specific graphical backends

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22856)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: paulrouget
Pushing b1b47d8 to master...
@bors-servo bors-servo merged commit a690d6f into servo:master May 10, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
UWP port automation moved this from In progress to Done May 10, 2019
@bors-servo bors-servo mentioned this pull request May 10, 2019
Merged
@jdm jdm mentioned this pull request May 10, 2019
Open
@jdm jdm mentioned this pull request Jun 30, 2019
Closed
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
None yet
Projects
UWP port
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@jdm @highfive @bors-servo @atouchet @paulrouget @CYBAI @asajeffrey
You can’t perform that action at this time.