Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Sync changes from mozilla-central. #22861
Merged
Conversation
But enable it in all tests because a lot of them rely on using it in the style="" attribute for example, or in inline stylesheets, which will no longer parse this (even in chrome documents), and we don't want to rewrite all the XUL and XBL tests. Differential Revision: https://phabricator.services.mozilla.com/D18027
Differential Revision: https://phabricator.services.mozilla.com/D18567
Differential Revision: https://phabricator.services.mozilla.com/D19001
Which is the only property that uses LengthPercentage alone. Differential Revision: https://phabricator.services.mozilla.com/D17737
This also makes us pass a few WPTs because we stop losing precision when serializing the computed value. Differential Revision: https://phabricator.services.mozilla.com/D17738
Also for the intersection observer root margin, since it was easier to fix it up and clean it up than not doing it. This is the first big step to get rid of nscoord. It duplicates a bit of logic in nsLayoutUtils since for now max/min-width/height are still represented with nsStyleCoord, but I think I prefer to land this incrementally. I didn't add helpers for the physical accessors of the style rect sides that nsStyleSides has (top/bottom/left/right) since I think we generally should encourage the logical versions, but let me know if you want me to do that. Differential Revision: https://phabricator.services.mozilla.com/D17739
…epr(C) representation. This patch: * Makes LengthPercentageOrAuto generic, and removes a bunch of code fo LengthPercentageOrNone, which was used only for servo and now can use the normal MaxLength (with a cfg() guard for the ExtremumLength variant). * Shrinks MaxLength / MozLength's repr(C) reperesentation by reducing enum nesting. The shrinking is in preparation for using them from C++ too, though that'd be a different bug. * Moves NonNegative usage to the proper places so that stuff for them can be derived. I did this on top of bug 1523071 to prove both that it could be possible and that stuff wasn't too messy. It got a bit messy, but just because of a bug I had fixed in bindgen long time ago already, so this updates bindgen's patch version to grab a fix instead of ugly workarounds :) Differential Revision: https://phabricator.services.mozilla.com/D17762
highfive
commented
Feb 10, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 10, 2019
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 10, 2019
style: Sync changes from mozilla-central. See each individual commit for details. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22861) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedFeb 10, 2019
•
edited by SimonSapin
See each individual commit for details.
This change is