Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central. #22861

Merged
merged 9 commits into from Feb 10, 2019
Merged

Commits on Feb 10, 2019

  1. style: Make -moz-binding chrome / UA only.

    But enable it in all tests because a lot of them rely on using it in the
    style="" attribute for example, or in inline stylesheets, which will no longer
    parse this (even in chrome documents), and we don't want to rewrite all the XUL
    and XBL tests.
    
    Differential Revision: https://phabricator.services.mozilla.com/D18027
    emilio committed Feb 10, 2019
  2. style: Add bindings for LengthPercentage, and use it for text-indent.

    Which is the only property that uses LengthPercentage alone.
    
    Differential Revision: https://phabricator.services.mozilla.com/D17737
    emilio committed Feb 10, 2019
  3. style: Use the style system's LengthPercentage for shape-margin.

    This also makes us pass a few WPTs because we stop losing precision when
    serializing the computed value.
    
    Differential Revision: https://phabricator.services.mozilla.com/D17738
    emilio committed Feb 10, 2019
  4. style: Use Rust lengths for margin / padding / inset.

    Also for the intersection observer root margin, since it was easier to fix it
    up and clean it up than not doing it.
    
    This is the first big step to get rid of nscoord. It duplicates a bit of logic
    in nsLayoutUtils since for now max/min-width/height are still represented with
    nsStyleCoord, but I think I prefer to land this incrementally.
    
    I didn't add helpers for the physical accessors of the style rect sides that
    nsStyleSides has (top/bottom/left/right) since I think we generally should
    encourage the logical versions, but let me know if you want me to do that.
    
    Differential Revision: https://phabricator.services.mozilla.com/D17739
    emilio committed Feb 10, 2019
  5. style: Derive more length stuff, and shrink MaxLength / MozLength's r…

    …epr(C) representation.
    
    This patch:
    
     * Makes LengthPercentageOrAuto generic, and removes a bunch of code fo
       LengthPercentageOrNone, which was used only for servo and now can use the
       normal MaxLength (with a cfg() guard for the ExtremumLength variant).
    
     * Shrinks MaxLength / MozLength's repr(C) reperesentation by reducing enum
       nesting. The shrinking is in preparation for using them from C++ too, though
       that'd be a different bug.
    
     * Moves NonNegative usage to the proper places so that stuff for them can be
       derived.
    
    I did this on top of bug 1523071 to prove both that it could be possible and
    that stuff wasn't too messy. It got a bit messy, but just because of a bug I
    had fixed in bindgen long time ago already, so this updates bindgen's patch
    version to grab a fix instead of ugly workarounds :)
    
    Differential Revision: https://phabricator.services.mozilla.com/D17762
    emilio committed Feb 10, 2019
  6. Fix servo build.

    emilio committed Feb 10, 2019
You can’t perform that action at this time.