Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servo-media #22872

Merged
merged 1 commit into from Feb 13, 2019
Merged

Update servo-media #22872

merged 1 commit into from Feb 13, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Feb 13, 2019 •
edited by SimonSapin

Pulls in servo/media#199, doesn't use it yet

This change is Reviewable
@highfive
Copy link

highfive commented Feb 13, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/rtcpeerconnection.rs, components/script/dom/mediastream.rs, components/script/dom/bindings/trace.rs, components/script/dom/mediadevices.rs
  • @KiChjang: components/script/dom/rtcpeerconnection.rs, components/script/dom/mediastream.rs, components/script/dom/bindings/trace.rs, components/script/dom/mediadevices.rs
@highfive
Copy link

highfive commented Feb 13, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@asajeffrey
Copy link
Member

asajeffrey commented Feb 13, 2019

Looks like it's failing test-tidy. Apart from that LGTM, you can r=me.
@asajeffrey
asajeffrey approved these changes Feb 13, 2019
View changes
Copy link
Member

asajeffrey left a comment

LGTM
@Manishearth Manishearth force-pushed the Manishearth:mediaup branch from 71b4275 to f531bbf Feb 13, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Feb 13, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2019

📌 Commit f531bbf has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2019

⌛ Testing commit f531bbf with merge cd51814...
bors-servo added a commit that referenced this pull request Feb 13, 2019
@bors-servo
Auto merge of #22872 - Manishearth:mediaup, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd51814 
Update servo-media

Pulls in servo/media#199, doesn't use it yet

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22872)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2019

💔 Test failed - magicleap
@Manishearth
Update servo-media
Loading status checks…
407d88f
@Manishearth Manishearth force-pushed the Manishearth:mediaup branch from f531bbf to 407d88f Feb 13, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Feb 13, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2019

📌 Commit 407d88f has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2019

⌛ Testing commit 407d88f with merge 093a1ee...
bors-servo added a commit that referenced this pull request Feb 13, 2019
@bors-servo
Auto merge of #22872 - Manishearth:mediaup, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
093a1ee 
Update servo-media

Pulls in servo/media#199, doesn't use it yet

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22872)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: asajeffrey
Pushing 093a1ee to master...
@bors-servo bors-servo merged commit 407d88f into servo:master Feb 13, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Manishearth @highfive @asajeffrey @bors-servo
You can’t perform that action at this time.