Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow the embedder to register their own VRServices #22886
Merged
+48
−45
Conversation
highfive
commented
Feb 13, 2019
|
Heads up! This PR modifies the following files:
|
|
r? @paulrouget or @Manishearth |
asajeffrey
force-pushed the
asajeffrey:webvr-embedder-can-register-vrservices
branch
from
02e0b29
to
a062c40
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 14, 2019
…ces, r=Manishearth Allow the embedder to register their own VRServices <!-- Please describe your changes on the following line: --> Allow the servo embedder to register their own `VRService`s, not just the default ones. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22878 - [X] These changes do not require tests because this is all plumbing <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22886) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedFeb 13, 2019
•
edited by SimonSapin
Allow the servo embedder to register their own
VRServices, not just the default ones../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is