Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the embedder to register their own VRServices #22886

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
6 participants
@asajeffrey
Copy link
Member

asajeffrey commented Feb 13, 2019

Allow the servo embedder to register their own VRServices, not just the default ones.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22878
  • These changes do not require tests because this is all plumbing

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Feb 13, 2019

Heads up! This PR modifies the following files:

  • @paulrouget: components/compositing/Cargo.toml, components/compositing/windowing.rs, components/servo/lib.rs
@asajeffrey

This comment has been minimized.

Copy link
Member Author

asajeffrey commented Feb 13, 2019

@highfive highfive assigned paulrouget and unassigned SimonSapin Feb 13, 2019

@asajeffrey asajeffrey force-pushed the asajeffrey:webvr-embedder-can-register-vrservices branch from 02e0b29 to a062c40 Feb 14, 2019

@asajeffrey

This comment has been minimized.

Copy link
Member Author

asajeffrey commented Feb 14, 2019

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 14, 2019

📌 Commit a062c40 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 14, 2019

⌛️ Testing commit a062c40 with merge 2c63d12...

bors-servo added a commit that referenced this pull request Feb 14, 2019

Auto merge of #22886 - asajeffrey:webvr-embedder-can-register-vrservi…
…ces, r=Manishearth

Allow the embedder to register their own VRServices

<!-- Please describe your changes on the following line: -->

Allow the servo embedder to register their own `VRService`s, not just the default ones.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22878
- [X] These changes do not require tests because this is all plumbing

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22886)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 14, 2019

@bors-servo bors-servo merged commit a062c40 into servo:master Feb 14, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.