Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Au::zero_* with generic methods #2289

Merged
merged 1 commit into from May 2, 2014
Merged

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented May 2, 2014

Depends on servo/euclid#33.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 2, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1437

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented May 2, 2014

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @mbrubeck, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!
bors-servo pushed a commit that referenced this pull request May 2, 2014
@metajack

This comment has been minimized.

Copy link

metajack commented on 4821df6 May 2, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 4821df6 May 2, 2014

saw approval from metajack
at mbrubeck@4821df6

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 2, 2014

merging mbrubeck/servo/zero-geom = 4821df6 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 2, 2014

mbrubeck/servo/zero-geom = 4821df6 merged ok, testing candidate = 85393c6

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 2, 2014

fast-forwarding master to auto = 85393c6

bors-servo pushed a commit that referenced this pull request May 2, 2014
@bors-servo bors-servo closed this May 2, 2014
@bors-servo bors-servo merged commit 4821df6 into servo:master May 2, 2014
1 check passed
1 check passed
default all tests passed
@mbrubeck mbrubeck deleted the mbrubeck:zero-geom branch Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.