Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd comment that compositor can block on layout #22913
Closed
Conversation
highfive
commented
Feb 19, 2019
|
Heads up! This PR modifies the following files:
|
|
Conversation with @glennw about whether this comment is correct. https://mozilla.logbot.info/servo/20190219#c15987234 |
|
This is actually a bug. #22914 |
asajeffrey
force-pushed the
asajeffrey:constellation-comment-compositor-can-block-on-layout
branch
from
f43dd8c
to
cfcc94d
|
Probably best not to update the docs in this case, since we'd be documenting a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedFeb 19, 2019
•
edited by SimonSapin
Add a comment that compositor can block on layout.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is