Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upimplement historical srcElement attribute for Event interface #22918
Conversation
highfive
commented
Feb 21, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
highfive
commented
Feb 21, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 21, 2019
cf938af
to
dd731aa
|
@bors-servo r+ |
|
|
implement historical srcElement attribute for Event interface <!-- Please describe your changes on the following line: --> Implementation of `srcElement` attribute for Event interface. Reference: https://dom.spec.whatwg.org/#dom-event-srcelement --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22880 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22918) <!-- Reviewable:end -->
|
Thanks! |
|
|
|
Need to update these test expectations!
|
|
@Manishearth updated the test expectations for this PR. Sorry for multiple commits - still getting to grips with my first PR into Servo. |
|
@bors-servo r+ |
|
|
implement historical srcElement attribute for Event interface <!-- Please describe your changes on the following line: --> Implementation of `srcElement` attribute for Event interface. Reference: https://dom.spec.whatwg.org/#dom-event-srcelement --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22880 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22918) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
implement historical srcElement attribute for Event interface <!-- Please describe your changes on the following line: --> Implementation of `srcElement` attribute for Event interface. Reference: https://dom.spec.whatwg.org/#dom-event-srcelement --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22880 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22918) <!-- Reviewable:end -->
|
|
|
Need to update some more test results:
|
|
@jdm is there a command i can run locally to discover these failing tests? |
|
@drexler I suggested that in my original issue comment in #22880 (comment) :) |
|
@bors-servo r- |
|
|
|
@drexler Are you planning to finish updating the test results? |
|
@jdm ooops...totally slipped off my radar. I'll tackle it tonight and update the PR. |
|
Closing due to inactivity. |
Event src element <!-- Please describe your changes on the following line: --> This builds on top of the work done in #22918 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22880 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24144) <!-- Reviewable:end -->
Event src element <!-- Please describe your changes on the following line: --> This builds on top of the work done in #22918 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22880 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24144) <!-- Reviewable:end -->
Event src element <!-- Please describe your changes on the following line: --> This builds on top of the work done in #22918 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22880 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24144) <!-- Reviewable:end -->
drexler commentedFeb 21, 2019
•
edited by SimonSapin
Implementation of
srcElementattribute for Event interface. Reference: https://dom.spec.whatwg.org/#dom-event-srcelement./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is