Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement historical srcElement attribute for Event interface #22918

Closed
wants to merge 1 commit into from

Conversation

@drexler
Copy link
Contributor

drexler commented Feb 21, 2019

Implementation of srcElement attribute for Event interface. Reference: https://dom.spec.whatwg.org/#dom-event-srcelement


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22880 (GitHub issue number if applicable)
  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

highfive commented Feb 21, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

@highfive
Copy link

highfive commented Feb 21, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/event.rs, components/script/dom/webidls/Event.webidl
  • @KiChjang: components/script/dom/event.rs, components/script/dom/webidls/Event.webidl
@highfive
Copy link

highfive commented Feb 21, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
components/script/dom/event.rs Outdated Show resolved Hide resolved
components/script/dom/event.rs Outdated Show resolved Hide resolved
@drexler drexler force-pushed the drexler:event-src-element branch from abfa1aa to 41218f5 Feb 21, 2019
@drexler drexler force-pushed the drexler:event-src-element branch 2 times, most recently from cf938af to dd731aa Feb 21, 2019
@Manishearth
Copy link
Member

Manishearth commented Feb 25, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2019

📌 Commit dd731aa has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2019

Testing commit dd731aa with merge e88f9a5...

bors-servo added a commit that referenced this pull request Feb 25, 2019
implement historical srcElement attribute for Event interface

<!-- Please describe your changes on the following line: -->
Implementation of `srcElement` attribute for Event interface. Reference: https://dom.spec.whatwg.org/#dom-event-srcelement

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22880 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22918)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member

Manishearth commented Feb 25, 2019

Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2019

💔 Test failed - linux-rel-css

@CYBAI
Copy link
Collaborator

CYBAI commented Feb 25, 2019

Need to update these test expectations!

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Event interface: attribute srcElement", 
    "test": "/dom/interfaces.html?exclude=Node", 
    "line": 89302, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Event interface: document.createEvent(\"Event\") must inherit property \"srcElement\" with the proper type", 
    "test": "/dom/interfaces.html?exclude=Node", 
    "line": 89329, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Event interface: new Event(\"foo\") must inherit property \"srcElement\" with the proper type", 
    "test": "/dom/interfaces.html?exclude=Node", 
    "line": 89354, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Event interface: new CustomEvent(\"foo\") must inherit property \"srcElement\" with the proper type", 
    "test": "/dom/interfaces.html?exclude=Node", 
    "line": 89390, 
    "action": "test_result", 
    "expected": "FAIL"
}
@drexler
Copy link
Contributor Author

drexler commented Feb 25, 2019

@Manishearth updated the test expectations for this PR. Sorry for multiple commits - still getting to grips with my first PR into Servo.

@Manishearth
Copy link
Member

Manishearth commented Feb 25, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2019

📌 Commit 96bff3c has been approved by Manishearth

bors-servo added a commit that referenced this pull request Mar 7, 2019
implement historical srcElement attribute for Event interface

<!-- Please describe your changes on the following line: -->
Implementation of `srcElement` attribute for Event interface. Reference: https://dom.spec.whatwg.org/#dom-event-srcelement

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22880 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22918)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

Testing commit fff8a09 with merge d364b28...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

💔 Test failed - linux-rel-css

@jdm
Copy link
Member

jdm commented Mar 7, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

Testing commit fff8a09 with merge ee00aa0...

bors-servo added a commit that referenced this pull request Mar 7, 2019
implement historical srcElement attribute for Event interface

<!-- Please describe your changes on the following line: -->
Implementation of `srcElement` attribute for Event interface. Reference: https://dom.spec.whatwg.org/#dom-event-srcelement

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22880 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22918)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

💔 Test failed - linux-rel-wpt

@jdm
Copy link
Member

jdm commented Mar 7, 2019

Need to update some more test results:


  ▶ Unexpected subtest result in /dom/events/Event-initEvent.html:
  └ PASS [expected FAIL] Properties of initEvent(type, true, true)

  ▶ Unexpected subtest result in /dom/events/Event-initEvent.html:
  └ PASS [expected FAIL] Properties of initEvent(type, true, false)

  ▶ Unexpected subtest result in /dom/events/Event-initEvent.html:
  └ PASS [expected FAIL] Properties of initEvent(type, false, true)

  ▶ Unexpected subtest result in /dom/events/Event-initEvent.html:
  └ PASS [expected FAIL] Properties of initEvent(type, false, false)
@drexler
Copy link
Contributor Author

drexler commented Mar 7, 2019

@jdm is there a command i can run locally to discover these failing tests?

@jdm
Copy link
Member

jdm commented Mar 7, 2019

@drexler I suggested that in my original issue comment in #22880 (comment) :)

@jdm
Copy link
Member

jdm commented May 2, 2019

@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2019

The latest upstream changes (presumably #23465) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm
Copy link
Member

jdm commented Jun 24, 2019

@drexler Are you planning to finish updating the test results?

@drexler
Copy link
Contributor Author

drexler commented Jun 24, 2019

@jdm ooops...totally slipped off my radar. I'll tackle it tonight and update the PR.

@jdm
Copy link
Member

jdm commented Sep 4, 2019

Closing due to inactivity.

@jdm jdm closed this Sep 4, 2019
@stephenmuss stephenmuss mentioned this pull request Sep 5, 2019
4 of 4 tasks complete
bors-servo added a commit that referenced this pull request Sep 5, 2019
Event src element

<!-- Please describe your changes on the following line: -->
This builds on top of the work done in #22918

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22880
- [X] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24144)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Sep 6, 2019
Event src element

<!-- Please describe your changes on the following line: -->
This builds on top of the work done in #22918

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22880
- [X] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24144)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Sep 6, 2019
Event src element

<!-- Please describe your changes on the following line: -->
This builds on top of the work done in #22918

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22880
- [X] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24144)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.