Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement historical returnValue attribute for Event interface #22933

Merged
merged 1 commit into from Mar 2, 2019
Merged

Implement historical returnValue attribute for Event interface #22933

merged 1 commit into from Mar 2, 2019

Conversation

@pngai
Copy link
Contributor

pngai commented Feb 24, 2019 •
edited

Implementation of returnValue attribute for Event interface.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22881 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable
@highfive
Copy link

highfive commented Feb 24, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon.
@highfive
Copy link

highfive commented Feb 24, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/event.rs, components/script/dom/webidls/Event.webidl
  • @KiChjang: components/script/dom/event.rs, components/script/dom/webidls/Event.webidl
@nox
nox reviewed Feb 24, 2019
View changes
components/script/dom/event.rs Show resolved Hide resolved
@pngai pngai force-pushed the pngai:implement-returnValue-attribute branch from 3c85753 to 4b51a47 Feb 25, 2019
@jdm
Copy link
Member

jdm commented Feb 27, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2019

📌 Commit 4b51a47 has been approved by jdm
@highfive highfive assigned jdm and unassigned avadacatavra Feb 27, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2019

⌛ Testing commit 4b51a47 with merge 52d5b09...
bors-servo added a commit that referenced this pull request Feb 27, 2019
@bors-servo
Auto merge of #22933 - pngai:implement-returnValue-attribute, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
52d5b09 
Implement historical returnValue attribute for Event interface

<!-- Please describe your changes on the following line: -->
Implementation of `returnValue` attribute for Event interface.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22881 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22933)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Feb 27, 2019 

  ▶ Unexpected subtest result in /dom/interfaces.html?exclude=Node:
  └ PASS [expected FAIL] Event interface: attribute returnValue

  ▶ Unexpected subtest result in /dom/interfaces.html?exclude=Node:
  └ PASS [expected FAIL] Event interface: document.createEvent("Event") must inherit property "returnValue" with the proper type

  ▶ Unexpected subtest result in /dom/interfaces.html?exclude=Node:
  └ PASS [expected FAIL] Event interface: new Event("foo") must inherit property "returnValue" with the proper type

  ▶ Unexpected subtest result in /dom/interfaces.html?exclude=Node:
  └ PASS [expected FAIL] Event interface: new CustomEvent("foo") must inherit property "returnValue" with the proper type
@jdm
Copy link
Member

jdm commented Feb 27, 2019

One more round of changes to ini files should do it.
@pngai
Implement historical returnValue attribute for Event interface
Loading status checks…
fcadff7
@pngai pngai force-pushed the pngai:implement-returnValue-attribute branch from 4b51a47 to fcadff7 Feb 28, 2019
@jdm
Copy link
Member

jdm commented Mar 1, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

📌 Commit fcadff7 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

⌛ Testing commit fcadff7 with merge b7602fc...
bors-servo added a commit that referenced this pull request Mar 1, 2019
@bors-servo
Auto merge of #22933 - pngai:implement-returnValue-attribute, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b7602fc 
Implement historical returnValue attribute for Event interface

<!-- Please describe your changes on the following line: -->
Implementation of `returnValue` attribute for Event interface.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22881 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22933)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Mar 1, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

⌛ Testing commit fcadff7 with merge 4d8d54f...
bors-servo added a commit that referenced this pull request Mar 1, 2019
@bors-servo
Auto merge of #22933 - pngai:implement-returnValue-attribute, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4d8d54f 
Implement historical returnValue attribute for Event interface

<!-- Please describe your changes on the following line: -->
Implementation of `returnValue` attribute for Event interface.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22881 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22933)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 4d8d54f to master...
@bors-servo bors-servo merged commit fcadff7 into servo:master Mar 2, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 2, 2019
Merged
4 of 4 tasks complete
@pngai pngai deleted the pngai:implement-returnValue-attribute branch Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox nox

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement historical returnValue attribute for Event interface
6 participants
@pngai @highfive @jdm @bors-servo @nox @avadacatavra
You can’t perform that action at this time.