Update WebIDL.py #22934

Manishearth · 2019-02-25T06:37:35Z

I'm working on getting attributes on types landed in upstream webidl. In preparation for that, I'd like to update WebIDL.py and deal with all the conflicts first so that updating for that bug is easier.

(This PR doesn't need to be reviewed and landed right now, I can just roll it into the PR for implementing attributes on types, but I suspect it would be easier to land this first)

Probably should squash before landing, the steps are separated out for ease of review.

r? @nox @jdm

This change is

highfive · 2019-02-25T06:37:39Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/bindings/codegen/parser/debug.patch, components/script/dom/bindings/codegen/parser/pref-main-thread.patch, components/script/dom/bindings/codegen/parser/tests/test_replaceable.py, components/script/dom/bindings/codegen/parser/tests/test_lenientSetter.py, components/script/dom/bindings/codegen/parser/abstract.patch and 5 more
@KiChjang: components/script/dom/bindings/codegen/parser/debug.patch, components/script/dom/bindings/codegen/parser/pref-main-thread.patch, components/script/dom/bindings/codegen/parser/tests/test_replaceable.py, components/script/dom/bindings/codegen/parser/tests/test_lenientSetter.py, components/script/dom/bindings/codegen/parser/abstract.patch and 5 more

Manishearth · 2019-02-25T06:37:54Z

This has not been built and tested yet, working on it

Manishearth · 2019-02-25T07:42:54Z

Works now. I reverted https://bugzilla.mozilla.org/show_bug.cgi?id=1368949 since nothing we use needs it yet and also implementing it in our codegen seemed tricky. I'll file a bug later.

Manishearth · 2019-02-25T07:43:02Z

@bors-servo try

bors-servo · 2019-02-25T07:43:09Z

⌛ Trying commit a5325bf with merge f1878a2...


        Auto merge of #22934 - Manishearth:update-webidl, r=<try>

@nox

Update WebIDL.py I'm working on getting [attributes on types landed in upstream webidl](https://bugzilla.mozilla.org/show_bug.cgi?id=1359269). In preparation for that, I'd like to update WebIDL.py and deal with all the conflicts first so that updating for that bug is easier. (This PR doesn't need to be reviewed and landed right now, I can just roll it into the PR for implementing attributes on types, but I suspect it would be easier to land this first) Probably should squash before landing, the steps are separated out for ease of review. r? @nox @jdm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22934)

bors-servo · 2019-02-25T09:13:39Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
State: approved= try=True

nox · 2019-02-28T20:55:02Z

Rather than undoing upstream stuff, could we rather just assert that we don't have nested dictionaries in CodegenRust.py?

Manishearth · 2019-03-01T04:02:04Z

No, we rely on dictionaries hitting the following isAny branch to codegen correctly.

nox · 2019-03-01T11:21:07Z

What? "the following isAny branch"? I don't want to have to remember that we reverted something from upstream, so please make CodegenRust.py cope with the new things that are parsed but that we don't support yet.

nox · 2019-03-01T11:22:14Z

Ah you made a patch ok. Well I guess that's fine, but I've always tried to minimise the amount of patches and that would be better as a check in CodegenRust.py.

r=me once everything is squashed and there is a single commit remaining.


        Update webidl.py from upstream

Manishearth · 2019-03-01T11:30:10Z

@bors-servo r=nox

thanks!

I may eventually upstream some of our patches in some form, so that they're reduced to at worst having a difference between Codegen.py and CodegenRust.py.

bors-servo · 2019-03-01T11:30:11Z

📌 Commit 8f5db8a has been approved by nox

bors-servo · 2019-03-01T11:30:15Z

⌛ Testing commit 8f5db8a with merge f708343...


        Auto merge of #22934 - Manishearth:update-webidl, r=nox

@nox

Update WebIDL.py I'm working on getting [attributes on types landed in upstream webidl](https://bugzilla.mozilla.org/show_bug.cgi?id=1359269). In preparation for that, I'd like to update WebIDL.py and deal with all the conflicts first so that updating for that bug is easier. (This PR doesn't need to be reviewed and landed right now, I can just roll it into the PR for implementing attributes on types, but I suspect it would be easier to land this first) Probably should squash before landing, the steps are separated out for ease of review. r? @nox @jdm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22934)

bors-servo · 2019-03-01T12:39:38Z

💔 Test failed - status-taskcluster

Manishearth · 2019-03-01T14:39:20Z

@bors-servo retry

timeout on tidy task, and network issue (?) on android:

* What went wrong:
A problem occurred configuring root project 'apk'.
> Could not resolve all files for configuration ':classpath'.
   > Could not download fastutil.jar (it.unimi.dsi:fastutil:7.2.0)
      > Could not get resource 'https://jcenter.bintray.com/it/unimi/dsi/fastutil/7.2.0/fastutil-7.2.0.jar'.
         > Connection reset
   > Could not download kotlin-reflect.jar (org.jetbrains.kotlin:kotlin-reflect:1.2.0)
      > Could not get resource 'https://jcenter.bintray.com/org/jetbrains/kotlin/kotlin-reflect/1.2.0/kotlin-reflect-1.2.0.jar'.
         > Connection reset

bors-servo · 2019-03-01T14:39:22Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-03-01T14:39:27Z

⌛ Testing commit 8f5db8a with merge bcbf720...


        Auto merge of #22934 - Manishearth:update-webidl, r=nox

@nox

Update WebIDL.py I'm working on getting [attributes on types landed in upstream webidl](https://bugzilla.mozilla.org/show_bug.cgi?id=1359269). In preparation for that, I'd like to update WebIDL.py and deal with all the conflicts first so that updating for that bug is easier. (This PR doesn't need to be reviewed and landed right now, I can just roll it into the PR for implementing attributes on types, but I suspect it would be easier to land this first) Probably should squash before landing, the steps are separated out for ease of review. r? @nox @jdm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22934)

bors-servo · 2019-03-01T15:57:06Z

💔 Test failed - status-taskcluster

Manishearth · 2019-03-01T16:25:41Z

@bors-servo retry

needs #22954 to land

bors-servo · 2019-03-01T16:38:09Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-03-01T16:38:13Z

⌛ Testing commit 8f5db8a with merge 75f9610...


        Auto merge of #22934 - Manishearth:update-webidl, r=nox

@nox

Update WebIDL.py I'm working on getting [attributes on types landed in upstream webidl](https://bugzilla.mozilla.org/show_bug.cgi?id=1359269). In preparation for that, I'd like to update WebIDL.py and deal with all the conflicts first so that updating for that bug is easier. (This PR doesn't need to be reviewed and landed right now, I can just roll it into the PR for implementing attributes on types, but I suspect it would be easier to land this first) Probably should squash before landing, the steps are separated out for ease of review. r? @nox @jdm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22934)

Manishearth · 2019-03-01T18:49:51Z

@bors-servo r=nox

bors-servo · 2019-03-01T18:49:52Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

bors-servo · 2019-03-01T18:49:53Z

📌 Commit 8f5db8a has been approved by nox

bors-servo · 2019-03-01T20:44:45Z

⌛ Testing commit 8f5db8a with merge 27f443f...


        Auto merge of #22934 - Manishearth:update-webidl, r=nox

@nox

Update WebIDL.py I'm working on getting [attributes on types landed in upstream webidl](https://bugzilla.mozilla.org/show_bug.cgi?id=1359269). In preparation for that, I'd like to update WebIDL.py and deal with all the conflicts first so that updating for that bug is easier. (This PR doesn't need to be reviewed and landed right now, I can just roll it into the PR for implementing attributes on types, but I suspect it would be easier to land this first) Probably should squash before landing, the steps are separated out for ease of review. r? @nox @jdm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22934)

bors-servo · 2019-03-01T22:19:01Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: nox
Pushing 27f443f to master...

bors-servo · 2019-03-02T02:38:13Z

💥 Test timed out

highfive assigned nox Feb 25, 2019

highfive added the S-awaiting-review label Feb 25, 2019

Manishearth force-pushed the Manishearth:update-webidl branch from 20a27a4 to d1c92ea Feb 25, 2019

Update webidl.py from upstream

Loading status checks…

8f5db8a

Manishearth force-pushed the Manishearth:update-webidl branch from a5325bf to 8f5db8a Mar 1, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 1, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 1, 2019

highfive removed the S-tests-failed label Mar 1, 2019

highfive added the S-awaiting-merge label Mar 1, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 1, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Mar 1, 2019

Manishearth closed this Mar 1, 2019

Manishearth reopened this Mar 1, 2019

highfive removed the S-awaiting-merge label Mar 1, 2019

bors-servo mentioned this pull request Mar 1, 2019

Implemented support for DataView in parsing WebIDL #22770

Closed

2 of 5 tasks complete

Manishearth deleted the Manishearth:update-webidl branch Mar 2, 2019

Manishearth mentioned this pull request Jun 27, 2019

Figure out what to do about optional dictionary members that are also dictionaries #23640

Closed

servo / servo

Update WebIDL.py #22934

Update WebIDL.py #22934

Manishearth commented Feb 25, 2019 •

edited by SimonSapin

highfive commented Feb 25, 2019

Manishearth commented Feb 25, 2019

Manishearth commented Feb 25, 2019

Manishearth commented Feb 25, 2019

bors-servo commented Feb 25, 2019

bors-servo commented Feb 25, 2019

nox commented Feb 28, 2019

Manishearth commented Mar 1, 2019 •

edited

nox commented Mar 1, 2019

nox commented Mar 1, 2019

Manishearth commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

Manishearth commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

Manishearth commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

Manishearth commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 2, 2019

servo / servo

Join GitHub today

Update WebIDL.py #22934

Update WebIDL.py #22934

Conversation

Manishearth commented Feb 25, 2019 • edited by SimonSapin

highfive commented Feb 25, 2019

Manishearth commented Feb 25, 2019

Manishearth commented Feb 25, 2019

Manishearth commented Feb 25, 2019

bors-servo commented Feb 25, 2019

bors-servo commented Feb 25, 2019

nox commented Feb 28, 2019

Manishearth commented Mar 1, 2019 • edited

nox commented Mar 1, 2019

nox commented Mar 1, 2019

Manishearth commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

Manishearth commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

Manishearth commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

Manishearth commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 1, 2019

bors-servo commented Mar 2, 2019

Manishearth commented Feb 25, 2019 •

edited by SimonSapin

Manishearth commented Mar 1, 2019 •

edited