Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPass the GL context to the VRDisplay when rendering #22939
Merged
Conversation
highfive
commented
Feb 25, 2019
|
|
|
Should land after servo/rust-webvr#63 |
asajeffrey
force-pushed the
asajeffrey:vrdisplay-gets-gl-bindings
branch
from
39e0d2e
to
cb85194
|
Only the commit "Pass the GL context to the VRDisplay when rendering" is part of this PR, the other one is #22938. |
|
r? @Manishearth or @paulrouget |
|
#22938 has landed, so this is ready for review. |
asajeffrey
force-pushed the
asajeffrey:vrdisplay-gets-gl-bindings
branch
from
cb85194
to
8ddde7e
|
Rebased. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 27, 2019
Pass the GL context to the VRDisplay when rendering <!-- Please describe your changes on the following line: --> Allow the VRDisplay access to the WebGL thread's GL bindings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's behind-the-scenes plumbing <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22939) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedFeb 25, 2019
•
edited by SimonSapin
Allow the VRDisplay access to the WebGL thread's GL bindings.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is