Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upShutdown player when HTMLMediaElement is dropped #22944
Merged
Conversation
highfive
commented
Feb 27, 2019
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ |
|
@ceyusa: |
|
@bors-servo r=ceyusa |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 27, 2019
Shutdown player when HTMLMediaElement is dropped - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22931 - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22944) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 27, 2019
Shutdown player when HTMLMediaElement is dropped - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22931 - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22944) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Feb 27, 2019
Shutdown player when HTMLMediaElement is dropped - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22931 - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22944) <!-- Reviewable:end -->
ferjm
force-pushed the
ferjm:player.shutdown
branch
2 times, most recently
from
8328825
to
31c4b30
bors-servo
added a commit
to servo/media
that referenced
this pull request
Mar 25, 2019
Temporarily disable GL functionality This should unblock updating servo-media in Servo while we work on a different workaround for the [existing build issues](servo/servo#22944 (comment)).
|
@bors-servo r=ceyusa |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 25, 2019
Shutdown player when HTMLMediaElement is dropped - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22931 - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22944) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
This was referenced Mar 25, 2019
Merged
ceyusa
added a commit
to ceyusa/media
that referenced
this pull request
Apr 6, 2019
This object is in charge of two tasks: - Create the video sink - Create the frames to push to the Renders The purpose of this design is to handle GL by another create (in order to workaround servo/servo#22944 (comment)), and that other object will proxy these tasks if available in the target OS. This patch removes temporarly the GL support in player.
ceyusa
added a commit
to ceyusa/media
that referenced
this pull request
Apr 10, 2019
This object is in charge of two tasks: - Create the video sink - Create the frames to push to the Renders The purpose of this design is to handle GL by another create (in order to workaround servo/servo#22944 (comment)), and that other object will proxy these tasks if available in the target OS. This patch removes temporarly the GL support in player.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedFeb 27, 2019
•
edited by SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is