Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the docs task into its own builder until it learns to behave #22954

Merged
merged 1 commit into from Mar 1, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 1, 2019

The latest rust update regressed rustdoc performance on servo a lot (6min to 37min), and now the tidy+unit+docs builder keeps timing out.

This splits out the doc task into its own thing until we can fix this.

r? @jdm


This change is Reviewable

@jdm
Copy link
Member

jdm commented Mar 1, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

📌 Commit b2bb879 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

Testing commit b2bb879 with merge a11c31c...

bors-servo added a commit that referenced this pull request Mar 1, 2019
Put the docs task into its own builder until it learns to behave

The latest rust update regressed rustdoc performance on servo a lot (6min to 37min), and now the tidy+unit+docs builder keeps timing out.

This splits out the doc task into its own thing until we can fix this.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22954)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

Manishearth commented Mar 1, 2019

@bors p=4

@Manishearth Manishearth mentioned this pull request Mar 1, 2019
@Manishearth Manishearth force-pushed the Manishearth:tc-docs-split branch from b2bb879 to 9ecc650 Mar 1, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Mar 1, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

📌 Commit 9ecc650 has been approved by jdm

bors-servo added a commit that referenced this pull request Mar 1, 2019
Put the docs task into its own builder until it learns to behave

The latest rust update regressed rustdoc performance on servo a lot (6min to 37min), and now the tidy+unit+docs builder keeps timing out.

This splits out the doc task into its own thing until we can fix this.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22954)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

Testing commit 9ecc650 with merge d712b71...

@SimonSapin
Copy link
Member

SimonSapin commented Mar 1, 2019

I think this is the right call here (to avoid increasing the total cycle time) but raising the timeout is also an option:

.with_max_run_time_minutes(60)

@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2019

@bors-servo bors-servo merged commit 9ecc650 into servo:master Mar 1, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:tc-docs-split branch Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.