Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for attributes on types in WebIDL #22958

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
4 participants
@Manishearth
Copy link
Member

Manishearth commented Mar 2, 2019

WebIDL moved [Clamp], [RangeEnforced], and [TreatNullAs] to applying directly to types in heycam/webidl#286.

I implemented parser support for this upstream in bug 1359269. This pull request downstreams those changes and updates codegen as well as any webidls to conform.

Needed to land #22874

r? @nox


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Mar 2, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/CSSStyleDeclaration.webidl, components/script/dom/webidls/CharacterData.webidl, components/script/dom/webidls/HTMLElement.webidl, components/script/dom/webidls/MediaList.webidl, components/script/dom/webidls/HTMLFontElement.webidl and 17 more
  • @KiChjang: components/script/dom/webidls/CSSStyleDeclaration.webidl, components/script/dom/webidls/CharacterData.webidl, components/script/dom/webidls/HTMLElement.webidl, components/script/dom/webidls/MediaList.webidl, components/script/dom/webidls/HTMLFontElement.webidl and 17 more
@nox

This comment has been minimized.

Copy link
Member

nox commented Mar 4, 2019

r=me once squashed.

@Manishearth Manishearth force-pushed the Manishearth:attrs-on-types branch from d119cfd to 7b48df5 Mar 4, 2019

@Manishearth

This comment has been minimized.

Copy link
Member Author

Manishearth commented Mar 4, 2019

@bors-servo r=nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 4, 2019

📌 Commit 7b48df5 has been approved by nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 4, 2019

⌛️ Testing commit 7b48df5 with merge 28c6dec...

bors-servo added a commit that referenced this pull request Mar 4, 2019

Auto merge of #22958 - Manishearth:attrs-on-types, r=nox
Add support for attributes on types in WebIDL

WebIDL moved `[Clamp]`, `[RangeEnforced]`, and `[TreatNullAs]` to applying directly to types in heycam/webidl#286.

I implemented parser support for this upstream in [bug 1359269](https://bugzilla.mozilla.org/show_bug.cgi?id=1359269). This pull request downstreams those changes and updates codegen as well as any webidls to conform.

Needed to land #22874

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22958)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 4, 2019

@bors-servo bors-servo merged commit 7b48df5 into servo:master Mar 4, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

bors-servo added a commit that referenced this pull request Mar 4, 2019

Auto merge of #22874 - Manishearth:constraint, r=jdm
Add support for MediaTrackConstraints

This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request Mar 4, 2019

Auto merge of #22874 - Manishearth:constraint, r=jdm
Add support for MediaTrackConstraints

This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request Mar 4, 2019

Auto merge of #22874 - Manishearth:constraint, r=jdm
Add support for MediaTrackConstraints

This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request Mar 4, 2019

Auto merge of #22874 - Manishearth:constraint, r=jdm
Add support for MediaTrackConstraints

This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.