Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for attributes on types in WebIDL #22958

Merged
merged 2 commits into from Mar 4, 2019
Merged

Add support for attributes on types in WebIDL #22958

merged 2 commits into from Mar 4, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 2, 2019 •
edited by SimonSapin

WebIDL moved [Clamp], [RangeEnforced], and [TreatNullAs] to applying directly to types in heycam/webidl#286.

I implemented parser support for this upstream in bug 1359269. This pull request downstreams those changes and updates codegen as well as any webidls to conform.

Needed to land #22874

r? @nox

This change is Reviewable
@Manishearth
Move pref-main-thread.patch back
5fa80a8
@highfive
Copy link

highfive commented Mar 2, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/CSSStyleDeclaration.webidl, components/script/dom/webidls/CharacterData.webidl, components/script/dom/webidls/HTMLElement.webidl, components/script/dom/webidls/MediaList.webidl, components/script/dom/webidls/HTMLFontElement.webidl and 17 more
  • @KiChjang: components/script/dom/webidls/CSSStyleDeclaration.webidl, components/script/dom/webidls/CharacterData.webidl, components/script/dom/webidls/HTMLElement.webidl, components/script/dom/webidls/MediaList.webidl, components/script/dom/webidls/HTMLFontElement.webidl and 17 more
@nox
Copy link
Member

nox commented Mar 4, 2019

r=me once squashed.
@Manishearth
Update WebIDL.py to 4166cae81546
Loading status checks…
7b48df5 
https://hg.mozilla.org/integration/autoland/rev/4166cae81546f54accae807413f806d20bf30920

Pulls in changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1359269
@Manishearth Manishearth force-pushed the Manishearth:attrs-on-types branch from d119cfd to 7b48df5 Mar 4, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Mar 4, 2019

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2019

📌 Commit 7b48df5 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2019

⌛ Testing commit 7b48df5 with merge 28c6dec...
bors-servo added a commit that referenced this pull request Mar 4, 2019
@bors-servo
Auto merge of #22958 - Manishearth:attrs-on-types, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
28c6dec 
Add support for attributes on types in WebIDL

WebIDL moved `[Clamp]`, `[RangeEnforced]`, and `[TreatNullAs]` to applying directly to types in heycam/webidl#286.

I implemented parser support for this upstream in [bug 1359269](https://bugzilla.mozilla.org/show_bug.cgi?id=1359269). This pull request downstreams those changes and updates codegen as well as any webidls to conform.

Needed to land #22874

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22958)
<!-- Reviewable:end -->
@Manishearth Manishearth mentioned this pull request Mar 4, 2019
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: nox
Pushing 28c6dec to master...
@bors-servo bors-servo merged commit 7b48df5 into servo:master Mar 4, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request Mar 4, 2019
@bors-servo
Auto merge of #22874 - Manishearth:constraint, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
12c60cb 
Add support for MediaTrackConstraints

This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 4, 2019
@bors-servo
Auto merge of #22874 - Manishearth:constraint, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db313cf 
Add support for MediaTrackConstraints

This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 4, 2019
@bors-servo
Auto merge of #22874 - Manishearth:constraint, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d6eef04 
Add support for MediaTrackConstraints

This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 4, 2019
@bors-servo
Auto merge of #22874 - Manishearth:constraint, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0f3108c 
Add support for MediaTrackConstraints

This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874)
<!-- Reviewable:end -->
@Manishearth Manishearth deleted the Manishearth:attrs-on-types branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Manishearth @highfive @nox @bors-servo
You can’t perform that action at this time.