Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various state tracking to RTCPeerConnection, add .close() #22974

Merged
merged 4 commits into from Mar 25, 2019
Merged

Add various state tracking to RTCPeerConnection, add .close() #22974

merged 4 commits into from Mar 25, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 6, 2019 •
edited

This adds support for signalingState, iceGatheringState, and iceConnectionState on RTCPeerConnection, as well as RTCPeerConnection::close()

This doesn't yet support connectionState.

r? @jdm

This change is Reviewable
@highfive
Copy link

highfive commented Mar 6, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/RTCPeerConnection.webidl, components/script/dom/rtcpeerconnection.rs, components/script/Cargo.toml, components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs and 2 more
  • @KiChjang: components/script/dom/webidls/RTCPeerConnection.webidl, components/script/dom/rtcpeerconnection.rs, components/script/Cargo.toml, components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs and 2 more
@highfive
Copy link

highfive commented Mar 6, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member Author

Manishearth commented Mar 6, 2019 •
edited

signalingState is a bit tricky and we may want to remove it from this PR, since I need to verify if it's okay to let the backend update our signaling state instead of proactively updating it when things happen. It's probably going to be a mix of the two.

I think for now this basic version is fine, though. When I make various methods rely on the signaling state I'll change it.
@Manishearth Manishearth force-pushed the Manishearth:webrtc-state branch from f85d3bc to 5c49d2f Mar 6, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Mar 6, 2019 

`"pkg-config" "--libs" "--cflags" "glib-2.0 >= 2.42"` did not exit successfully: exit code: 1

probably a bootstrap dep somewhere. I'm surprised servo-media's travis didn't catch it.
@jdm
Copy link
Member

jdm commented Mar 6, 2019

@Manishearth See if you prefer the changes from master...jdm:media-invert for the servo-media update commit.
@jdm
Copy link
Member

jdm commented Mar 6, 2019

We probably either need to integrate the changes from #22944 and #22949 or wait for them to be merged.
@jdm
jdm approved these changes Mar 6, 2019
View changes
Copy link
Member

jdm left a comment

The WebRTC changes look fine.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2019

☔ The latest upstream changes (presumably #22973) made this pull request unmergeable. Please resolve the merge conflicts.
Manishearth added 4 commits Mar 6, 2019
@Manishearth
Add ICEGatheringState to RTCPeerConnection
209caa4
@Manishearth
Add ICEConnectionState to RTCPeerConnection
fc25a80
@Manishearth
Add SignalingState to RTCPeerConnection
5cb5503
@Manishearth
Add RTCPeerConnection::Close
Loading status checks…
7343241
@Manishearth Manishearth force-pushed the Manishearth:webrtc-state branch from 5c49d2f to 7343241 Mar 25, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Mar 25, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2019

📌 Commit 7343241 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2019

⌛ Testing commit 7343241 with merge f45bea7...
bors-servo added a commit that referenced this pull request Mar 25, 2019
@bors-servo
Auto merge of #22974 - Manishearth:webrtc-state, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f45bea7 
Add various state tracking to RTCPeerConnection, add .close()

This adds support for `signalingState`, `iceGatheringState`, and `iceConnectionState` on RTCPeerConnection, as well as `RTCPeerConnection::close()`

This doesn't yet support `connectionState`.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22974)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing f45bea7 to master...
@bors-servo bors-servo merged commit 7343241 into servo:master Mar 25, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:webrtc-state branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
S-blocked-on-external
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Manishearth @highfive @jdm @bors-servo
You can’t perform that action at this time.