Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unnecessary synchronous full reflow. #22995

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
5 participants
@jdm
Copy link
Member

jdm commented Mar 7, 2019

We already reflow any nodes that are dirtied during any turn of the event loop. There is no reason to synchronously reflow the entire document, especially when we don't even modify it in this method.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22988
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Mar 7, 2019

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

highfive commented Mar 7, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Copy link
Member Author

jdm commented Mar 7, 2019

r? @nox

@highfive highfive assigned nox and unassigned Manishearth Mar 7, 2019

@nox

This comment has been minimized.

Copy link
Member

nox commented Mar 8, 2019

@bors-servo r+

Nice catch.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

📌 Commit a8683bc has been approved by nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

⌛️ Testing commit a8683bc with merge f0c62f4...

bors-servo added a commit that referenced this pull request Mar 8, 2019

Auto merge of #22995 - servo:jdm-patch-28, r=nox
Remove an unnecessary synchronous full reflow.

We already reflow any nodes that are dirtied during any turn of the event loop. There is no reason to synchronously reflow the entire document, especially when we don't even modify it in this method.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22988
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22995)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

💔 Test failed - mac-rel-wpt2

@jdm

This comment has been minimized.

Copy link
Member Author

jdm commented Mar 8, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

⌛️ Testing commit a8683bc with merge db29cb0...

bors-servo added a commit that referenced this pull request Mar 8, 2019

Auto merge of #22995 - servo:jdm-patch-28, r=nox
Remove an unnecessary synchronous full reflow.

We already reflow any nodes that are dirtied during any turn of the event loop. There is no reason to synchronously reflow the entire document, especially when we don't even modify it in this method.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22988
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22995)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

@bors-servo bors-servo merged commit a8683bc into master Mar 8, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.