Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacement logic when navigating nested browsing contexts #22999

Merged
merged 2 commits into from Mar 8, 2019

Conversation

Projects
None yet
6 participants
@jdm
Copy link
Member

jdm commented Mar 7, 2019

These changes also fix a bug where traversing the session history in a nested browsing context did not update the iframe's contentWindow appropriately.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22996
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Mar 7, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmliframeelement.rs, components/constellation/pipeline.rs, components/constellation/constellation.rs, components/script/script_thread.rs, components/constellation/session_history.rs
  • @cbrewster: components/constellation/pipeline.rs, components/constellation/constellation.rs, components/constellation/session_history.rs
  • @paulrouget: components/constellation/pipeline.rs, components/constellation/constellation.rs, components/constellation/session_history.rs
  • @KiChjang: components/script/dom/htmliframeelement.rs, components/script/script_thread.rs, components/script_traits/lib.rs
@jdm

This comment has been minimized.

Copy link
Member Author

jdm commented Mar 7, 2019

r? @asajeffrey
This is session history and window proxies for double the fun!

@highfive highfive assigned asajeffrey and unassigned ferjm Mar 7, 2019

@jdm jdm force-pushed the jdm:iframe-replace branch from b34c313 to 1c0315c Mar 8, 2019

Make nested browsing context navigations check the loaded status of t…
…he active document of the nested browsing context.

@jdm jdm force-pushed the jdm:iframe-replace branch from 1c0315c to c2ce7d7 Mar 8, 2019

@jdm jdm referenced this pull request Mar 8, 2019

Merged

Make webgl behave better with session history #23000

4 of 4 tasks complete
@asajeffrey

This comment has been minimized.

Copy link
Member

asajeffrey commented Mar 8, 2019

Oh joy, session history. This all LGTM, might be worth running it by @cbrewster who has looked at it more recently than I have. You can r=me.

@cbrewster

This comment has been minimized.

Copy link
Member

cbrewster commented Mar 8, 2019

LGTM as well

@jdm

This comment has been minimized.

Copy link
Member Author

jdm commented Mar 8, 2019

@bors-servo r=asajeffrey,cbrewster

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

📌 Commit c2ce7d7 has been approved by asajeffrey,cbrewster

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

⌛️ Testing commit c2ce7d7 with merge ac3c002...

bors-servo added a commit that referenced this pull request Mar 8, 2019

Auto merge of #22999 - jdm:iframe-replace, r=asajeffrey,cbrewster
Fix replacement logic when navigating nested browsing contexts

These changes also fix a bug where traversing the session history in a nested browsing context did not update the iframe's contentWindow appropriately.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22996
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22999)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 8, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: asajeffrey,cbrewster
Pushing ac3c002 to master...

@bors-servo bors-servo merged commit c2ce7d7 into servo:master Mar 8, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Mar 8, 2019

Open

Shutdown player when HTMLMediaElement is dropped #22944

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.