Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebDriver FindElementFromElement command #23008

Merged
merged 1 commit into from Mar 12, 2019
Merged

Implement WebDriver FindElementFromElement command #23008

merged 1 commit into from Mar 12, 2019

Conversation

@georgeroman
Copy link
Contributor

georgeroman commented Mar 9, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
@georgeroman
Implement WebDriver FindElementFromElement command
Loading status checks…
46cd0d1
@highfive
Copy link

highfive commented Mar 9, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/script_thread.rs, components/script/webdriver_handlers.rs, components/webdriver_server/lib.rs
  • @jgraham: components/webdriver_server/lib.rs
  • @KiChjang: components/script/script_thread.rs, components/script_traits/webdriver_msg.rs, components/script/webdriver_handlers.rs
@highfive
Copy link

highfive commented Mar 9, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@CYBAI
CYBAI reviewed Mar 10, 2019
View changes
components/webdriver_server/lib.rs
@@ -766,6 +766,42 @@ impl Handler {
}
}

// https://w3c.github.io/webdriver/#find-element-from-element
fn handle_find_element_element(

This comment has been minimized.

Sign in to view
@CYBAI

CYBAI Mar 10, 2019

Collaborator

How about let's use the name element from element for this feature?
ElementElement looks not easy to understand for me 😂

ex. handle_find_element_from_element, FindElementFromElement

This comment has been minimized.

Sign in to view
@georgeroman

georgeroman Mar 10, 2019

Author Contributor

element from element also sounds better to me, but I wanted to keep the name consistent with that of the webdriver crate command: https://searchfox.org/mozilla-central/source/testing/webdriver/src/command.rs
@Manishearth
Copy link
Member

Manishearth commented Mar 11, 2019

@bors-servo r+

thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2019

📌 Commit 46cd0d1 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2019

⌛ Testing commit 46cd0d1 with merge bc4737a...
bors-servo added a commit that referenced this pull request Mar 11, 2019
@bors-servo
Auto merge of #23008 - georgeroman:implement_webdriver_find_elem_from…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bc4737a 
…_elem, r=Manishearth

Implement WebDriver FindElementFromElement command

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23008)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Mar 11, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2019

⌛ Testing commit 46cd0d1 with merge a307f55...
bors-servo added a commit that referenced this pull request Mar 11, 2019
@bors-servo
Auto merge of #23008 - georgeroman:implement_webdriver_find_elem_from…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a307f55 
…_elem, r=Manishearth

Implement WebDriver FindElementFromElement command

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23008)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2019

💔 Test failed - mac-rel-wpt3
@jdm
Copy link
Member

jdm commented Mar 11, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 12, 2019

⌛ Testing commit 46cd0d1 with merge 9513544...
bors-servo added a commit that referenced this pull request Mar 12, 2019
@bors-servo
Auto merge of #23008 - georgeroman:implement_webdriver_find_elem_from…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9513544 
…_elem, r=Manishearth

Implement WebDriver FindElementFromElement command

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23008)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 12, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: Manishearth
Pushing 9513544 to master...
@bors-servo bors-servo merged commit 46cd0d1 into servo:master Mar 12, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CYBAI CYBAI

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@georgeroman @highfive @Manishearth @bors-servo @jdm @CYBAI
You can’t perform that action at this time.