Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StyleSheet.insertRule WebIDL to make index optional. #23029

Merged
merged 1 commit into from Mar 20, 2019

Conversation

Projects
None yet
5 participants
@KwanEsq
Copy link
Contributor

commented Mar 13, 2019

Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an @import rule to insertRule
leads to "Expected a stylesheet loader for @import"


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23025
  • There are tests for these changes
  • ./mach test-wpt css/cssom passes with these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 13, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented Mar 13, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/CSSStyleSheet.webidl
  • @KiChjang: components/script/dom/webidls/CSSStyleSheet.webidl
Update StyleSheet.insertRule WebIDL to make index optional.
Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an @import rule to insertRule
leads to "Expected a stylesheet loader for @import"

Fixes #23025

@KwanEsq KwanEsq force-pushed the KwanEsq:insertRuleNoIndex branch from b6d5b16 to 948e169 Mar 13, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

@SimonSapin Review ping

@SimonSapin

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

Looks good, thanks!

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

📌 Commit 948e169 has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

⌛️ Testing commit 948e169 with merge 056cb6a...

bors-servo added a commit that referenced this pull request Mar 20, 2019

Auto merge of #23029 - KwanEsq:insertRuleNoIndex, r=SimonSapin
Update StyleSheet.insertRule WebIDL to make index optional.

Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an \@import rule to insertRule
leads to "Expected a stylesheet loader for \@import"

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23025
- [x] There are tests for these changes
- [x] ./mach test-wpt css/cssom passes with these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23029)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

⌛️ Testing commit 948e169 with merge 43cc2a0...

bors-servo added a commit that referenced this pull request Mar 20, 2019

Auto merge of #23029 - KwanEsq:insertRuleNoIndex, r=SimonSapin
Update StyleSheet.insertRule WebIDL to make index optional.

Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an \@import rule to insertRule
leads to "Expected a stylesheet loader for \@import"

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23025
- [x] There are tests for these changes
- [x] ./mach test-wpt css/cssom passes with these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23029)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@bors-servo bors-servo merged commit 948e169 into servo:master Mar 20, 2019

3 of 4 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@KwanEsq KwanEsq deleted the KwanEsq:insertRuleNoIndex branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.