Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate StyleSheet.insertRule WebIDL to make index optional. #23029
Conversation
highfive
commented
Mar 13, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon. |
highfive
commented
Mar 13, 2019
|
Heads up! This PR modifies the following files:
|
|
@SimonSapin Review ping |
|
Looks good, thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 20, 2019
Update StyleSheet.insertRule WebIDL to make index optional. Update wpt metadata to show the new passes. Add one test as crashing since currently passing an \@import rule to insertRule leads to "Expected a stylesheet loader for \@import" --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23025 - [x] There are tests for these changes - [x] ./mach test-wpt css/cssom passes with these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23029) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 20, 2019
Update StyleSheet.insertRule WebIDL to make index optional. Update wpt metadata to show the new passes. Add one test as crashing since currently passing an \@import rule to insertRule leads to "Expected a stylesheet loader for \@import" --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23025 - [x] There are tests for these changes - [x] ./mach test-wpt css/cssom passes with these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23029) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
KwanEsq commentedMar 13, 2019
•
edited
Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an @import rule to insertRule
leads to "Expected a stylesheet loader for @import"
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is