Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XMLSerializer interface #23044

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
5 participants
@georgeroman
Copy link
Contributor

commented Mar 15, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22997

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 15, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/xmlserializer.rs, components/script/dom/webidls/XMLSerializer.webidl, components/script/dom/mod.rs
  • @KiChjang: components/script/dom/xmlserializer.rs, components/script/dom/webidls/XMLSerializer.webidl, components/script/dom/mod.rs

@georgeroman georgeroman force-pushed the georgeroman:implement_xmlserializer branch from 6d445e9 to c8ebb40 Mar 16, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

I have filed servo/html5ever#368 about implementing the full XML serialization algorithm, which should allow the remaining tests to pass. That's a lot of work, though, and I won't prevent these changes from landing until it's done. Thanks!

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

📌 Commit c8ebb40 has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Mar 18, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

☔️ The latest upstream changes (presumably #22891) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

🔒 Merge conflict

@georgeroman georgeroman force-pushed the georgeroman:implement_xmlserializer branch from c8ebb40 to c74663c Mar 19, 2019

@georgeroman georgeroman force-pushed the georgeroman:implement_xmlserializer branch from c74663c to 0fc8ee0 Mar 20, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

☔️ The latest upstream changes (presumably #23051) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Ack, sorry for not noticing this was ready to merge.

@jdm

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

✌️ @georgeroman can now approve this pull request

@georgeroman georgeroman force-pushed the georgeroman:implement_xmlserializer branch from 0fc8ee0 to c6433ef Mar 21, 2019

@georgeroman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

📌 Commit c6433ef has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

⌛️ Testing commit c6433ef with merge c2357f6...

bors-servo added a commit that referenced this pull request Mar 21, 2019

Auto merge of #23044 - georgeroman:implement_xmlserializer, r=jdm
Implement XMLSerializer interface

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #22997

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23044)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@bors-servo retry

  • Network issue
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

⌛️ Testing commit c6433ef with merge 4e0b483...

bors-servo added a commit that referenced this pull request Mar 21, 2019

Auto merge of #23044 - georgeroman:implement_xmlserializer, r=jdm
Implement XMLSerializer interface

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #22997

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23044)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

💔 Test failed - mac-rel-wpt2

@jdm

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

⌛️ Testing commit c6433ef with merge ba92920...

bors-servo added a commit that referenced this pull request Mar 21, 2019

Auto merge of #23044 - georgeroman:implement_xmlserializer, r=jdm
Implement XMLSerializer interface

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #22997

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23044)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@bors-servo bors-servo merged commit c6433ef into servo:master Mar 21, 2019

3 of 4 checks passed

Travis CI - Pull Request Build Errored
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.