Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync WPT with upstream (15-03-2019) #23046

Closed

Conversation

@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Mar 16, 2019

Automated downstream sync of changes from upstream as of 15-03-2019.
[no-wpt-sync]


This change is Reviewable

@jdm
Copy link
Member

jdm commented Mar 16, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2019

📌 Commit 86523cd has been approved by jdm

@highfive highfive assigned jdm and unassigned paulrouget Mar 16, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2019

Testing commit 86523cd with merge 6bd69bc...

bors-servo added a commit that referenced this pull request Mar 16, 2019
Sync WPT with upstream (15-03-2019)

Automated downstream sync of changes from upstream as of 15-03-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23046)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2019

💔 Test failed - linux-rel-css

@CYBAI
Copy link
Collaborator

CYBAI commented Mar 17, 2019

Failure in Travis

36.71s$ ./mach test-tidy --no-progress --all
 0:07.10 INFO Diffing old and new manifests /home/travis/build/servo/servo/tests/wpt/mozilla/meta/MANIFEST.json
Error running mach:
    ['test-tidy', '--no-progress', '--all']
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You should consider filing a bug for this issue.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
AttributeError: 'SupportFile' object has no attribute 'meta_key'
  File "/home/travis/build/servo/servo/python/servo/testing_commands.py", line 330, in test_tidy
    manifest_dirty = run_update(self.context.topdir, check_clean=True)
  File "/home/travis/build/servo/servo/python/servo/testing_commands.py", line 90, in run_update
    return manifestupdate.update(logger, wpt_dir, check_clean, rebuild)
  File "/home/travis/build/servo/servo/tests/wpt/manifestupdate.py", line 54, in update
    return _check_clean(logger, test_paths)
  File "/home/travis/build/servo/servo/tests/wpt/manifestupdate.py", line 86, in _check_clean
    if not diff_manifests(logger, manifest_path, old_manifest, new_manifest):
  File "/home/travis/build/servo/servo/tests/wpt/manifestupdate.py", line 113, in diff_manifests
    for item in test.meta_key())
The command "./mach test-tidy --no-progress --all" exited with 1.

and the linux-rel-css failed with

  ▶ FAIL [expected PASS] /css/CSS2/text/white-space-003.xht
  └   → /css/CSS2/text/white-space-003.xht 176a7d7217da6442e19d9c32b5940424189a8bd0
/css/CSS2/text/white-space-001-ref.xht be47dca27b1ba0f26939434b91c1ba8ae840201b
@CYBAI
Copy link
Collaborator

CYBAI commented Mar 20, 2019

Close this one because @jdm is working on fixing WPT sync at #23051

@CYBAI CYBAI closed this Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.