Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync WPT with upstream (17-03-2019) #23051

Merged
merged 8 commits into from Mar 21, 2019
Merged

Sync WPT with upstream (17-03-2019) #23051

merged 8 commits into from Mar 21, 2019

Conversation

@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Mar 18, 2019 •
edited by SimonSapin

Automated downstream sync of changes from upstream as of 17-03-2019.
[no-wpt-sync]

This change is Reviewable
@highfive
Copy link

highfive commented Mar 18, 2019

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/webgl/meta/conformance/textures/misc/texture-upload-size.html.ini
@CYBAI
Copy link
Collaborator

CYBAI commented Mar 18, 2019

Same failure as #23046 in Travis

$ ./mach test-tidy --no-progress --all
 0:06.87 INFO Diffing old and new manifests /home/travis/build/servo/servo/tests/wpt/mozilla/meta/MANIFEST.json
Error running mach:
    ['test-tidy', '--no-progress', '--all']
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You should consider filing a bug for this issue.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
AttributeError: 'SupportFile' object has no attribute 'meta_key'
  File "/home/travis/build/servo/servo/python/servo/testing_commands.py", line 330, in test_tidy
    manifest_dirty = run_update(self.context.topdir, check_clean=True)
  File "/home/travis/build/servo/servo/python/servo/testing_commands.py", line 90, in run_update
    return manifestupdate.update(logger, wpt_dir, check_clean, rebuild)
  File "/home/travis/build/servo/servo/tests/wpt/manifestupdate.py", line 54, in update
    return _check_clean(logger, test_paths)
  File "/home/travis/build/servo/servo/tests/wpt/manifestupdate.py", line 86, in _check_clean
    if not diff_manifests(logger, manifest_path, old_manifest, new_manifest):
  File "/home/travis/build/servo/servo/tests/wpt/manifestupdate.py", line 113, in diff_manifests
    for item in test.meta_key())
The command "./mach test-tidy --no-progress --all" exited with 1.
@jdm
Copy link
Member

jdm commented Mar 20, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2019

📌 Commit 4988063 has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio Mar 20, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2019

⌛ Testing commit 4988063 with merge 9e3a316...
bors-servo added a commit that referenced this pull request Mar 20, 2019
@bors-servo
Auto merge of #23051 - servo-wpt-sync:wpt_update_17-03-2019, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e3a316 
Sync WPT with upstream (17-03-2019)

Automated downstream sync of changes from upstream as of 17-03-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23051)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2019

💔 Test failed - linux-rel-css
@CYBAI CYBAI mentioned this pull request Mar 20, 2019
Closed
servo-wpt-sync and others added 8 commits Mar 18, 2019
@servo-wpt-sync @jdm
Update web-platform-tests to revision c2e5b9fbaa17424f05ca2bb04609790…
f2c1b70 
…a3b61d5c2
@jdm
Rebuild all manifests.
7b4d1c6
@jdm
Make rebuild flag work.
6428901
@jdm
Make unclean manifest error show actual erroring manifest.
33f5066
@jdm
Stop using deprecated meta_key API.
cc7e210
@jdm
Cherry-pick web-platform-tests/wpt#15932 from upstream.
17e04fb
@jdm
Cherry-pick web-platform-tests/wpt#15949 from upstream.
3a46bf6
@jdm
Stop using deprecated manifest loading APIs.
Loading status checks…
fa0194f
@jdm jdm force-pushed the servo-wpt-sync:wpt_update_17-03-2019 branch from 17cef22 to fa0194f Mar 20, 2019
@jdm
Copy link
Member

jdm commented Mar 20, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2019

📌 Commit fa0194f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2019

⌛ Testing commit fa0194f with merge 03742be...
bors-servo added a commit that referenced this pull request Mar 20, 2019
@bors-servo
Auto merge of #23051 - servo-wpt-sync:wpt_update_17-03-2019, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03742be 
Sync WPT with upstream (17-03-2019)

Automated downstream sync of changes from upstream as of 17-03-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23051)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Mar 20, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2019

⌛ Testing commit fa0194f with merge 93dc229...
bors-servo added a commit that referenced this pull request Mar 20, 2019
@bors-servo
Auto merge of #23051 - servo-wpt-sync:wpt_update_17-03-2019, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
93dc229 
Sync WPT with upstream (17-03-2019)

Automated downstream sync of changes from upstream as of 17-03-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23051)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 93dc229 to master...
@bors-servo bors-servo mentioned this pull request Mar 21, 2019
Merged
3 of 3 tasks complete
@bors-servo bors-servo merged commit fa0194f into servo:master Mar 21, 2019
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@servo-wpt-sync @highfive @CYBAI @jdm @bors-servo @emilio
You can’t perform that action at this time.