Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCompare gstreamer version via `pkg-config --modversion` in bootstrap python script #23069
+1
−1
Conversation
CYBAI
changed the title
|
@bors-servo try
|
bors-servo
added a commit
that referenced
this pull request
Mar 21, 2019
Compare gstreamer version via `pkg-config --modversion` in bootstrap python script Not sure why calling `["pkg-config", "gstreamer-1.0 >= 1.12"]` did not work for some people on Mojave. (Btw, I'm also on Mojave but checking version with `gstreamer-1.0 >= 1.12` works fine for me🤔 ) I'd like to send this PR and ask bors to try to see if this will also work for other platform. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23015 - [x] These changes do not require tests because it tries to fix building issue <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23069) <!-- Reviewable:end -->
|
@Feliix42 helped to check this patch works! (#23015 (comment)) |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 25, 2019
Compare gstreamer version via `pkg-config --modversion` in bootstrap python script Not sure why calling `["pkg-config", "gstreamer-1.0 >= 1.12"]` did not work for some people on Mojave. (Btw, I'm also on Mojave but checking version with `gstreamer-1.0 >= 1.12` works fine for me🤔 ) I'd like to send this PR and ask bors to try to see if this will also work for other platform. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23015 - [x] These changes do not require tests because it tries to fix building issue <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23069) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 26, 2019
Compare gstreamer version via `pkg-config --modversion` in bootstrap python script Not sure why calling `["pkg-config", "gstreamer-1.0 >= 1.12"]` did not work for some people on Mojave. (Btw, I'm also on Mojave but checking version with `gstreamer-1.0 >= 1.12` works fine for me🤔 ) I'd like to send this PR and ask bors to try to see if this will also work for other platform. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23015 - [x] These changes do not require tests because it tries to fix building issue <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23069) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 26, 2019
Compare gstreamer version via `pkg-config --modversion` in bootstrap python script Not sure why calling `["pkg-config", "gstreamer-1.0 >= 1.12"]` did not work for some people on Mojave. (Btw, I'm also on Mojave but checking version with `gstreamer-1.0 >= 1.12` works fine for me🤔 ) I'd like to send this PR and ask bors to try to see if this will also work for other platform. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23015 - [x] These changes do not require tests because it tries to fix building issue <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23069) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CYBAI commentedMar 21, 2019
•
edited by SimonSapin
Not sure why calling🤔 )
["pkg-config", "gstreamer-1.0 >= 1.12"]did not work for some people on Mojave. (Btw, I'm also on Mojave but checking version withgstreamer-1.0 >= 1.12works fine for meI'd like to send this PR and ask bors to try to see if this will also work for other platform.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is