Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse mozjs profiling feature when building with frame pointer enabled #23095
+16
−12
Conversation
highfive
commented
Mar 25, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 25, 2019
|
|
jdm
changed the title
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 26, 2019
Use mozjs profiling feature when building with frame pointer enabled This makes it possible to get more meaningful profiles with #23080. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #23081 - [x] There are no tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23095) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 26, 2019
Use mozjs profiling feature when building with frame pointer enabled This makes it possible to get more meaningful profiles with #23080. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #23081 - [x] There are no tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23095) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 26, 2019
Use mozjs profiling feature when building with frame pointer enabled This makes it possible to get more meaningful profiles with #23080. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #23081 - [x] There are no tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23095) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMar 25, 2019
•
edited by SimonSapin
This makes it possible to get more meaningful profiles with #23080.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is