Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.35.0-nightly (4c27fb19b 2019-03-25) #23102

Merged
merged 1 commit into from Mar 27, 2019
Merged

Upgrade to rustc 1.35.0-nightly (4c27fb19b 2019-03-25) #23102

merged 1 commit into from Mar 27, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Mar 26, 2019

This change is Reviewable

@highfive
Copy link

highfive commented Mar 26, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/error.rs, components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/bindings/error.rs, components/script/dom/webglrenderingcontext.rs
  • @emilio: components/style/bloom.rs, components/style/font_face.rs, components/style/stylist.rs
@highfive
Copy link

highfive commented Mar 26, 2019

warning Warning warning

  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@SimonSapin
Copy link
Member Author

SimonSapin commented Mar 26, 2019

Extra careful review of the script_plugins change would be appreciated. rustc-internal APIs around HIR IDs have had a lot of churn lately, and with each change I grow less and less confident that the plugin still actually does what it was intended to do.

There is a unnecessary path disambiguator warning in components/config/tests/prefs.rs that is not caught by lints being denied (rust-lang/rust#58055), but applying the suggested chang “try removing ::” fails, possibly because this syn::Path macro input is used in two places: in a #foo::new() expression, and in a HashMap<String, #foo> type. I suspect one of them causes the warning when :: is used, and the other an error when it is not. Anyway, this warning is being removed entirely (rust-lang/rust#57565).

@Manishearth
Copy link
Member

Manishearth commented Mar 26, 2019

@bors-servo r+

the hir id change is pretty straightforward, it affected clippy too

@bors-servo
Copy link
Contributor

bors-servo commented Mar 26, 2019

📌 Commit 389e69b has been approved by Manishearth

@highfive highfive assigned Manishearth and unassigned paulrouget Mar 26, 2019
bors-servo added a commit that referenced this pull request Mar 27, 2019
Upgrade to rustc 1.35.0-nightly (4c27fb19b 2019-03-25)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23102)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2019

Testing commit 389e69b with merge 5da1de6...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2019

@bors-servo bors-servo merged commit 389e69b into master Mar 27, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Manishearth Manishearth deleted the rustup branch Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.