Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the target when packaging for magicleap #23117

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Mar 27, 2019

If we don't set the target during packaging, we get errors checking for gstreamer.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it fixes packaging errors.

This change is Reviewable

@highfive
Copy link

highfive commented Mar 27, 2019

Heads up! This PR modifies the following files:

@asajeffrey
Copy link
Member Author

asajeffrey commented Mar 27, 2019

As seen at #23114:

$ MAGICLEAP_SDK=/Users/ajeffrey/MagicLeap/mlsdk/v0.19.0 MLCERT=/Users/ajeffrey/MagicLeap/cert/alanjeffreymlcert.cert ./mach package -r --magicleap
Error running mach:

    ['package', '-r', '--magicleap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Your system's gstreamer libraries are out of date (we need at least 1.12). If you're unable to install them, let us know by filing a bug!

  File "/Users/ajeffrey/github/asajeffrey/servo/python/servo/package_commands.py", line 215, in package
    env = self.build_env(target=target)
  File "/Users/ajeffrey/github/asajeffrey/servo/python/servo/command_base.py", line 612, in build_env
    if self.needs_gstreamer_env(target):
  File "/Users/ajeffrey/github/asajeffrey/servo/python/servo/command_base.py", line 560, in needs_gstreamer_env
    install them, let us know by filing a bug!")
@jdm
Copy link
Member

jdm commented Mar 27, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2019

📌 Commit 733ff95 has been approved by jdm

@highfive highfive assigned jdm and unassigned paulrouget Mar 27, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2019

Testing commit 733ff95 with merge cd8b9ca...

bors-servo added a commit that referenced this pull request Mar 27, 2019
Set the target when packaging for magicleap

<!-- Please describe your changes on the following line: -->

If we don't set the target during packaging, we get errors checking for gstreamer.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it fixes packaging errors.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23117)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2019

@bors-servo bors-servo merged commit 733ff95 into servo:master Mar 27, 2019
3 of 4 checks passed
3 of 4 checks passed
Travis CI - Pull Request Build Errored
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.