Implement WheelEvent interface #23154

robert-snakard · 2019-04-02T00:43:48Z

Created a new dom interface: "WheelEvent" and added WPT tests to confirm the interface works. To do this I had to do the following:

Create a new WheelEvent dom interface. It can be found in script/dom/wheelevent.rs and dom/webidls/WheelEvent.webidl
Add a new WheelEvent option to the compositor's CompositorEvent enum
Add a new Wheel option to the compositor's WindowEvent enum
Add a new WheelDelta type to the script_traits module
Modify the scroll_event logic. Now we send a WheelEvent before scrolling. Repeat: we send the WheelEvent notification BEFORE we send the scroll delta.
Add two manual wpt tests to the uievents/order-of-events test collection

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22843 (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because ___

This change is

highfive · 2019-04-02T00:43:55Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon.

highfive · 2019-04-02T00:43:55Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/mod.rs, components/script/dom/mouseevent.rs, components/script/dom/window.rs, components/script/dom/document.rs, components/script/script_thread.rs and 3 more
@wafflespeanut: python/servo/build_commands.py
@cbrewster: components/constellation/constellation.rs
@paulrouget: ports/servo/glutin_app/window.rs, components/servo/lib.rs, ports/servo/browser.rs, components/compositing/compositor.rs, components/compositing/windowing.rs and 1 more
@KiChjang: components/script/dom/mod.rs, components/script/dom/mouseevent.rs, components/script/dom/window.rs, components/script_traits/lib.rs, components/script/dom/document.rs and 3 more

highfive · 2019-04-02T00:43:57Z

Warning

These commits modify unsafe code. Please review it carefully!

robert-snakard · 2019-04-02T00:44:15Z

@jdm

servo-wpt-sync · 2019-04-02T00:45:03Z

Error syncing changes upstream. Logs saved in error-snapshot-1554165902717.

jdm · 2019-04-02T00:49:50Z

@robert-snakard Looks like this needs to be rebased in a way that doesn't include commits which are already present on master.

robert-snakard · 2019-04-02T00:54:02Z

This should just be master with 2 commits on top...

jdm · 2019-04-02T00:57:02Z

It's possible that because the @bors-servo merge commits are missing it is not actually equivalent to master. I recommend doing a hard reset to master and cherry-picking your two commits, then force pushing.

servo-wpt-sync · 2019-04-02T01:26:07Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#16199.

servo-wpt-sync · 2019-04-02T02:18:26Z

PR title changed; changed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#16199.

robert-snakard · 2019-04-03T23:59:15Z

@jdm Updated the branch version and tested on my machine, the patch still works. Do I need to do anything else?

jdm · 2019-04-08T13:49:01Z

No, we just need to review these changes now.

jdm · 2019-04-08T13:49:32Z

@paulrouget Review ping?

jdm · 2019-04-09T13:32:27Z

@bors-servo try=wpt


        Auto merge of #23154 - robert-snakard:issue_22843, r=<try>

Implement WheelEvent interface Created a new dom interface: "WheelEvent" and added WPT tests to confirm the interface works. To do this I had to do the following: - Create a new `WheelEvent` dom interface. It can be found in `script/dom/wheelevent.rs` and `dom/webidls/WheelEvent.webidl` - Add a new `WheelEvent` option to the compositor's `CompositorEvent` enum - Add a new `Wheel` option to the compositor's `WindowEvent` enum - Add a new `WheelDelta` type to the `script_traits` module - Modify the `scroll_event` logic. Now we send a `WheelEvent` before scrolling. Repeat: we send the WheelEvent notification BEFORE we send the scroll delta. - Add two manual wpt tests to the `uievents/order-of-events` test collection ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22843 (GitHub issue number if applicable)  - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23154)

bors-servo · 2019-04-09T13:32:39Z

⌛ Trying commit 9e01a45 with merge cdd4cb0...

bors-servo · 2019-04-09T13:52:39Z

💔 Test failed - linux-rel-css

robert-snakard · 2019-04-09T17:00:38Z

This failed because tests that were supposed to fail are now passing, looking for the idlharness now to update it

robert-snakard · 2019-04-09T17:44:02Z

@bors-servo try=wpt

bors-servo · 2019-04-09T17:44:03Z

@robert-snakard: 🔑 Insufficient privileges: not in try users

jdm · 2019-06-07T21:03:16Z


  ▶ Unexpected subtest result in /uievents/idlharness.window.html:
  └ PASS [expected FAIL] MouseEvent interface: new WheelEvent("event") must inherit property "buttons" with the proper type

robert-snakard · 2019-06-07T21:05:48Z

Missed that one when merging with the mousebuttons patch. Will fix tonight. Is there any way to run these tests on my local machine before I push?

…

On Fri, Jun 7, 2019 at 2:03 PM Josh Matthews ***@***.***> wrote: ▶ Unexpected subtest result in /uievents/idlharness.window.html: └ PASS [expected FAIL] MouseEvent interface: new WheelEvent("event") must inherit property "buttons" with the proper type — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23154?email_source=notifications&email_token=ADFBHKRGRGLXVMHKMTLEJQTPZLEKTA5CNFSM4HC3T5M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXG7SXA#issuecomment-500037980>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADFBHKWUW2XIWB2SWFVYPZTPZLEKTANCNFSM4HC3T5MQ> .

jdm · 2019-06-07T21:07:29Z

You can run individual tests or directories with ./mach test-wpt /uievents/idlharness.window.html or ./mach test-wpt /uievents/ (for example), but running all of the tests locally is a mostly futile effort because there are so many of them.

jdm · 2019-06-07T21:39:47Z

Looks like these tests as well:

  ▶ Unexpected subtest result in /dom/events/Event-subclasses-constructors.html:
  └ PASS [expected FAIL] WheelEvent constructor (no argument)

  ▶ Unexpected subtest result in /dom/events/Event-subclasses-constructors.html:
  └ PASS [expected FAIL] WheelEvent constructor (undefined argument)

  ▶ Unexpected subtest result in /dom/events/Event-subclasses-constructors.html:
  └ PASS [expected FAIL] WheelEvent constructor (null argument)

  ▶ Unexpected subtest result in /dom/events/Event-subclasses-constructors.html:
  └ PASS [expected FAIL] WheelEvent constructor (empty argument)

  ▶ Unexpected subtest result in /dom/events/Event-subclasses-constructors.html:
  └ PASS [expected FAIL] WheelEvent constructor (argument with default values)

Otherwise it should be ready :)

servo-wpt-sync · 2019-06-08T05:49:08Z

Error syncing changes upstream. Logs saved in error-snapshot-1559972947848.

servo-wpt-sync · 2019-06-08T05:49:32Z

Error syncing changes upstream. Logs saved in error-snapshot-1559972971985.


        Implement WheelEvent Interface

Note: The WheelEvent interface supports rotation in all 3 spatial dimensions. This implementation only supports two due to limitations in the Glutin compositor. The wheelevent interface is a dom interface that triggers for any attached device that can rotate in one or more spatial dimensions. Traditionally this is the mouse wheel though other devices could be used as well. E.g. the trackball on a trackball mouse.


        Add WPT tests for WheelEvent

The wheelevent sends a signal when a supported device is rotated in the x, y, or z rotational dimensions. These tests only check whether this signal is received for any rotation at all.

servo-wpt-sync · 2019-06-09T17:27:38Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#16199.

jdm · 2019-06-09T17:28:43Z

@bors-servo r=paulrouget

bors-servo · 2019-06-09T17:28:44Z

📌 Commit 52a8f5a has been approved by paulrouget

bors-servo · 2019-06-09T17:55:07Z

⌛ Testing commit 52a8f5a with merge 973a344...


        Auto merge of #23154 - robert-snakard:issue_22843, r=paulrouget

Implement WheelEvent interface Created a new dom interface: "WheelEvent" and added WPT tests to confirm the interface works. To do this I had to do the following: - Create a new `WheelEvent` dom interface. It can be found in `script/dom/wheelevent.rs` and `dom/webidls/WheelEvent.webidl` - Add a new `WheelEvent` option to the compositor's `CompositorEvent` enum - Add a new `Wheel` option to the compositor's `WindowEvent` enum - Add a new `WheelDelta` type to the `script_traits` module - Modify the `scroll_event` logic. Now we send a `WheelEvent` before scrolling. Repeat: we send the WheelEvent notification BEFORE we send the scroll delta. - Add two manual wpt tests to the `uievents/order-of-events` test collection ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22843 (GitHub issue number if applicable)  - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23154)

bors-servo · 2019-06-09T20:40:47Z

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: paulrouget
Pushing 973a344 to master...

robert-snakard · 2019-07-17T19:28:58Z

Thanks for finishing the merge up for me @jdm / @paulrouget

jdm · 2019-07-17T19:34:35Z

Thanks for doing the hard work :)

robert-snakard · 2019-07-17T19:36:01Z

Haha, we must have different definitions of hard work, that merge took forever!

highfive assigned paulrouget Apr 2, 2019

highfive added the S-awaiting-review label Apr 2, 2019

robert-snakard mentioned this pull request Apr 2, 2019

Implement WheelEvent interface #22843

Closed

jdm added the S-needs-rebase label Apr 2, 2019

robert-snakard force-pushed the robert-snakard:issue_22843 branch from ef4adf8 to 9e01a45 Apr 2, 2019

servo-wpt-sync mentioned this pull request Apr 2, 2019

Implement WheelEvent interface web-platform-tests/wpt#16199

Merged

jdm changed the title ~~Issue 22843~~ Implement WheelEvent interface Apr 2, 2019

highfive added the S-tests-failed label Apr 9, 2019

robert-snakard force-pushed the robert-snakard:issue_22843 branch from 9e01a45 to 99e99b8 Apr 9, 2019

highfive removed the S-tests-failed label Apr 9, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 7, 2019

robert-snakard force-pushed the robert-snakard:issue_22843 branch from c44a49c to cc16f43 Jun 8, 2019

highfive added S-awaiting-review and removed S-tests-failed labels Jun 8, 2019

robert-snakard force-pushed the robert-snakard:issue_22843 branch from cc16f43 to 219df9b Jun 8, 2019

robert-snakard added 2 commits Feb 24, 2019

Add WPT tests for WheelEvent

Loading status checks…

52a8f5a

The wheelevent sends a signal when a supported device is rotated in the x, y, or z rotational dimensions. These tests only check whether this signal is received for any rotation at all.

jdm force-pushed the robert-snakard:issue_22843 branch from 219df9b to 52a8f5a Jun 9, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 9, 2019

highfive removed the S-awaiting-merge label Jun 9, 2019

This was referenced Jun 9, 2019

Clean-up navigation #23368

Merged

Media player rendering with GL textures #23483

Merged

servo / servo

Implement WheelEvent interface #23154

Implement WheelEvent interface #23154

robert-snakard commented Apr 2, 2019 •

edited by jdm

highfive commented Apr 2, 2019

highfive commented Apr 2, 2019

highfive commented Apr 2, 2019

robert-snakard commented Apr 2, 2019

servo-wpt-sync commented Apr 2, 2019

jdm commented Apr 2, 2019

robert-snakard commented Apr 2, 2019

jdm commented Apr 2, 2019

servo-wpt-sync commented Apr 2, 2019

servo-wpt-sync commented Apr 2, 2019

robert-snakard commented Apr 3, 2019

jdm commented Apr 8, 2019

jdm commented Apr 8, 2019

jdm commented Apr 9, 2019

bors-servo commented Apr 9, 2019

bors-servo commented Apr 9, 2019

robert-snakard commented Apr 9, 2019

robert-snakard commented Apr 9, 2019

bors-servo commented Apr 9, 2019

jdm commented Jun 7, 2019

robert-snakard commented Jun 7, 2019

jdm commented Jun 7, 2019

jdm commented Jun 7, 2019

servo-wpt-sync commented Jun 8, 2019

servo-wpt-sync commented Jun 8, 2019

servo-wpt-sync commented Jun 9, 2019

jdm commented Jun 9, 2019

bors-servo commented Jun 9, 2019

bors-servo commented Jun 9, 2019

bors-servo commented Jun 9, 2019

robert-snakard commented Jul 17, 2019

jdm commented Jul 17, 2019

robert-snakard commented Jul 17, 2019

servo / servo

Join GitHub today

Implement WheelEvent interface #23154

Implement WheelEvent interface #23154

Conversation

robert-snakard commented Apr 2, 2019 • edited by jdm

highfive commented Apr 2, 2019

highfive commented Apr 2, 2019

highfive commented Apr 2, 2019

robert-snakard commented Apr 2, 2019

servo-wpt-sync commented Apr 2, 2019

jdm commented Apr 2, 2019

robert-snakard commented Apr 2, 2019

jdm commented Apr 2, 2019

servo-wpt-sync commented Apr 2, 2019

servo-wpt-sync commented Apr 2, 2019

robert-snakard commented Apr 3, 2019

jdm commented Apr 8, 2019

jdm commented Apr 8, 2019

jdm commented Apr 9, 2019

bors-servo commented Apr 9, 2019

bors-servo commented Apr 9, 2019

robert-snakard commented Apr 9, 2019

robert-snakard commented Apr 9, 2019

bors-servo commented Apr 9, 2019

jdm commented Jun 7, 2019

robert-snakard commented Jun 7, 2019

jdm commented Jun 7, 2019

jdm commented Jun 7, 2019

servo-wpt-sync commented Jun 8, 2019

servo-wpt-sync commented Jun 8, 2019

servo-wpt-sync commented Jun 9, 2019

jdm commented Jun 9, 2019

bors-servo commented Jun 9, 2019

bors-servo commented Jun 9, 2019

bors-servo commented Jun 9, 2019

robert-snakard commented Jul 17, 2019

jdm commented Jul 17, 2019

robert-snakard commented Jul 17, 2019

robert-snakard commented Apr 2, 2019 •

edited by jdm