Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaStream playback through audio and video elements #23157

Merged
merged 2 commits into from Apr 14, 2019
Merged

MediaStream playback through audio and video elements #23157

merged 2 commits into from Apr 14, 2019

Conversation

@ferjm
Copy link
Member

ferjm commented Apr 3, 2019 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Apr 3, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/rtcpeerconnection.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs, components/script/dom/mediastream.rs
  • @KiChjang: components/script/dom/rtcpeerconnection.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs, components/script/dom/mediastream.rs
@highfive
Copy link

highfive commented Apr 3, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@ferjm ferjm force-pushed the ferjm:gum.playback branch from ed74bfd to 1e00ebe Apr 8, 2019
@ferjm
Copy link
Member Author

ferjm commented Apr 8, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Apr 8, 2019
@bors-servo
Auto merge of #23157 - ferjm:gum.playback, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aaa2f67 
[WIP] MediaStream playback through audio and video elements

- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23157)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2019

⌛ Trying commit 1e00ebe with merge aaa2f67...
@ferjm ferjm changed the title [WIP] MediaStream playback through audio and video elements MediaStream playback through audio and video elements Apr 8, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2019

💔 Test failed - linux-rel-css
@ferjm
MediaStream playback through audio and video elements
Loading status checks…
af242a0
@ferjm ferjm force-pushed the ferjm:gum.playback branch from 1e00ebe to af242a0 Apr 10, 2019
@ferjm
Copy link
Member Author

ferjm commented Apr 10, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2019

⌛ Trying commit af242a0 with merge 3e86be6...
bors-servo added a commit that referenced this pull request Apr 10, 2019
@bors-servo
Auto merge of #23157 - ferjm:gum.playback, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3e86be6 
MediaStream playback through audio and video elements

- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23157)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2019

💔 Test failed - linux-rel-css
@ferjm
Do not tie media element 'muted' state change to player availability
Loading status checks…
0eb2c1d
@ferjm
Copy link
Member Author

ferjm commented Apr 11, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2019

⌛ Trying commit 0eb2c1d with merge 7f58d8e...
bors-servo added a commit that referenced this pull request Apr 11, 2019
@bors-servo
Auto merge of #23157 - ferjm:gum.playback, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7f58d8e 
MediaStream playback through audio and video elements

- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23157)
<!-- Reviewable:end -->
@ferjm
Copy link
Member Author

ferjm commented Apr 11, 2019

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Apr 11, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@Manishearth
Copy link
Member

Manishearth commented Apr 13, 2019 •
edited by jdm

@bors-servo r+ try-
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2019

📌 Commit 0eb2c1d has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2019

⌛ Testing commit 0eb2c1d with merge 1720454...
bors-servo added a commit that referenced this pull request Apr 14, 2019
@bors-servo
Auto merge of #23157 - ferjm:gum.playback, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1720454 
MediaStream playback through audio and video elements

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23157)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: Manishearth
Pushing 1720454 to master...
@bors-servo bors-servo merged commit 0eb2c1d into servo:master Apr 14, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:gum.playback branch Apr 22, 2019
@Manishearth Manishearth mentioned this pull request May 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@ferjm @highfive @bors-servo @Manishearth @nox
You can’t perform that action at this time.